[java-support] 20/26: JSPT-115 - Enforce ContextHandlingHttpClient constructor contracts

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch dev/JSPT-111
in repository java-support.

View the commit online:
http://git.shibboleth.net/view/?p=java-support.git;a=commit;h=42ed8f75d8431b20ef97ee711ccf9e3c398a12b8

commit 42ed8f75d8431b20ef97ee711ccf9e3c398a12b8
Author: Ian Young <ian at iay.org.uk>
AuthorDate: Thu Mar 3 16:44:39 2022 +0000

    JSPT-115 - Enforce ContextHandlingHttpClient constructor contracts
    
    https://shibboleth.atlassian.net/browse/JSPT-115
---
 .../utilities/java/support/httpclient/ContextHandlingHttpClient.java | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/main/java/net/shibboleth/utilities/java/support/httpclient/ContextHandlingHttpClient.java b/src/main/java/net/shibboleth/utilities/java/support/httpclient/ContextHandlingHttpClient.java
index dd980da..b5d3c3c 100644
--- a/src/main/java/net/shibboleth/utilities/java/support/httpclient/ContextHandlingHttpClient.java
+++ b/src/main/java/net/shibboleth/utilities/java/support/httpclient/ContextHandlingHttpClient.java
@@ -18,7 +18,6 @@
 package net.shibboleth.utilities.java.support.httpclient;
 
 import java.io.IOException;
-import java.util.Collections;
 import java.util.List;
 
 import javax.annotation.Nonnull;
@@ -82,7 +81,7 @@ class ContextHandlingHttpClient extends CloseableHttpClient {
      * @param client the wrapped client instance
      */
     public ContextHandlingHttpClient(@Nonnull final CloseableHttpClient client) {
-        this(client, null);
+        this(client, List.of());
     }
 
     /**
@@ -94,7 +93,7 @@ class ContextHandlingHttpClient extends CloseableHttpClient {
     public ContextHandlingHttpClient(@Nonnull final CloseableHttpClient client, 
             @Nonnull final List<HttpClientContextHandler> staticHandlers) {
         httpClient = Constraint.isNotNull(client, "HttpClient was null");
-        handlers = staticHandlers != null ? staticHandlers : Collections.emptyList();
+        handlers = Constraint.isNotNull(staticHandlers, "staticHandlers was null");
     }
 
     /** {@inheritDoc} */

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.