[JIRA] (IDP-1888) Add duplicate property detection to the context initializer

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on IDP-1888 ( https://shibboleth.atlassian.net/browse/IDP-1888?atlOrigin=eyJpIjoiNmQzMjVkNTdmYWJlNDU1M2IyMzBmMDdkMDYyYmVkOTkiLCJwIjoiaiJ9 )

Re: Add duplicate property detection to the context initializer ( https://shibboleth.atlassian.net/browse/IDP-1888?atlOrigin=eyJpIjoiNmQzMjVkNTdmYWJlNDU1M2IyMzBmMDdkMDYyYmVkOTkiLCJwIjoiaiJ9 )

The conclusion here is that path comparison (at least on windows) is totally wrong. For instance a path /foo/bar is not absolute because it does’t start with
 }}  or a dos device. But  {{ ./foo/bar does not match a/foo/bar because it does raw string comparison and end up comparsing. with a. There is also a helpful comment TODO should do case insensitive checking which completely ingores the reality on the ground that you can get case sensitive file names (and of late this is a *per directory* characteristic - which is almost as broken)

Anyway the easiest thing appears to be to convert the manifest constant IDP_PROPERTIES into a path and then back to a string and then compare that. That way we are comparing whatever nonsense came back from the per OS implementation of path.

( https://shibboleth.atlassian.net/browse/IDP-1888#add-comment?atlOrigin=eyJpIjoiNmQzMjVkNTdmYWJlNDU1M2IyMzBmMDdkMDYyYmVkOTkiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1888#add-comment?atlOrigin=eyJpIjoiNmQzMjVkNTdmYWJlNDU1M2IyMzBmMDdkMDYyYmVkOTkiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100197- sha1:666e164 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220403/8c97c7c9/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-015d47e3-4ad6-4b92-869b-650b72f3ef98
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220403/8c97c7c9/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-10773b91-b854-4a46-87a6-4945562788db
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220403/8c97c7c9/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-e08cdcfc-d49e-40ec-87ae-2bed755058ba
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220403/8c97c7c9/attachment-0005.png>