[JIRA] (JCOMOIDC-23) Add OpenID Provider Configuration Document Resolver

[Philip Smart (Jira)]

Philip Smart ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5afecdc1eb3ffa0c596652c4 ) *commented* on JCOMOIDC-23 ( https://shibboleth.atlassian.net/browse/JCOMOIDC-23?atlOrigin=eyJpIjoiM2IzNjFmNTQyOTMzNDQ4Nzk5YTdhMWI5OTQzYmVlMjUiLCJwIjoiaiJ9 )

Re: Add OpenID Provider Configuration Document Resolver ( https://shibboleth.atlassian.net/browse/JCOMOIDC-23?atlOrigin=eyJpIjoiM2IzNjFmNTQyOTMzNDQ4Nzk5YTdhMWI5OTQzYmVlMjUiLCJwIjoiaiJ9 )

A very basic working version has been added to the dev/JCOMOIDC-23 branch. It does not contain:

* A cache sweeper
* A way to resolve metadata without an identifier e.g. entityID or Issuer.
* A way to load and save from a persistent cache - as that is coupled to XML ATM.
* The metrics are disabled - for no real reason other than to keep it simple for now.

The new use of generics is maybe a bit cumbersome, although it mostly works for the time being.

The caching is a very big part of the dynamic resolver logic, but seems coupled to the abstract classes. It may be worth looking to encapsulate that a bit e.g. into a caching engine or similar. Its neat use of per-entity locking would need to be carried over, the other cache primitives seem sensible/normal unless I have missed something - there is the secondary index for dealing with unknown entities that I need to understand better.

To make it more generic, a few method calls (new and old) have to be pushed down to the implementing class. Although maybe the general approach could be a bit different e.g. more strategies and or call-outs to pluggable parts.

Minor points: There are a few nonnull annotations in the existing class that look wrong, and I am not sure ‘initializing’ is ever used.

( https://shibboleth.atlassian.net/browse/JCOMOIDC-23#add-comment?atlOrigin=eyJpIjoiM2IzNjFmNTQyOTMzNDQ4Nzk5YTdhMWI5OTQzYmVlMjUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JCOMOIDC-23#add-comment?atlOrigin=eyJpIjoiM2IzNjFmNTQyOTMzNDQ4Nzk5YTdhMWI5OTQzYmVlMjUiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100175- sha1:d2d2b0f )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20210902/a6e28138/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-a826058e-999f-4849-9e00-f21b12c1715d
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20210902/a6e28138/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-c3ac8519-e5e5-4bae-8c3f-e5e5229d0fa1
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20210902/a6e28138/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-05fe0e77-f752-4db1-9eb1-17997a7ddfcf
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20210902/a6e28138/attachment-0005.png>