[JIRA] (IDP-1869) Investigate a new IdPAttributeValue type to handle scope variables

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on IDP-1869 ( https://shibboleth.atlassian.net/browse/IDP-1869?atlOrigin=eyJpIjoiODk5ZTU5YThmMTIxNGQyNDg1M2YwN2MyZDBjNmM4YTciLCJwIjoiaiJ9 )

Re: Investigate a new IdPAttributeValue type to handle scope variables ( https://shibboleth.atlassian.net/browse/IDP-1869?atlOrigin=eyJpIjoiODk5ZTU5YThmMTIxNGQyNDg1M2YwN2MyZDBjNmM4YTciLCJwIjoiaiJ9 )

> 
> 
> 
> We’ve always explicitly defined scoped data to mean there’s a value and a
> scope
> 
> 

Fair enough but I think that this means that the code structure (scope inherit from string) is marginally better that the alternative I was looking at (in which it doesn’t).

The trouble is that it boils down to :

* “Scoped should be like string except when isn’t” (the current case)

versus

* “Scoped should be unlike string except when it is” (what I was proposing).

In the case I tripped over ( AttributeValueStringMatcher ) the code has no idea about scoped values and it works because in that case we want scoped to behave like string.

So we are replacing one set of casting issues (where we need to check for Scoped because its behavior is different) with another (where we need to check for Scoped because its behavior is the same).

The correct design would have been to have had an abstract “StringBearingAttributeValue” class and to derive scoped & string from that. Then we could have, from day one, designed the code so that it worked at the right level of abstraction. But that's not where we are at and it would be massively disruptive and destabilising to do that.

Happy to be argued down but I think this means that this is a “won’t do”.

( https://shibboleth.atlassian.net/browse/IDP-1869#add-comment?atlOrigin=eyJpIjoiODk5ZTU5YThmMTIxNGQyNDg1M2YwN2MyZDBjNmM4YTciLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1869#add-comment?atlOrigin=eyJpIjoiODk5ZTU5YThmMTIxNGQyNDg1M2YwN2MyZDBjNmM4YTciLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100183- sha1:51e3c50 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20211023/8f8185e2/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-c0bbf7f7-4627-4f32-a935-283925058f4b
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211023/8f8185e2/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-fc26486a-b6e3-48fd-a041-bbd02a4315ea
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211023/8f8185e2/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-b99dd69f-2e51-4da0-927f-ed090a30ba9a
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211023/8f8185e2/attachment-0005.png>