[JIRA] (IDP-1872) Use __Host- prefix cookie names to ensure cookies come from the host

[Philip Brusten (Jira)]

Philip Brusten ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5b87bcb44d21642beb80e004 ) *commented* on IDP-1872 ( https://shibboleth.atlassian.net/browse/IDP-1872?atlOrigin=eyJpIjoiMGNmMGUwM2YzNjYyNDVjNmE4MDg3NGE4NGU3NWRmYWQiLCJwIjoiaiJ9 )

Re: Use __Host- prefix cookie names to ensure cookies come from the host ( https://shibboleth.atlassian.net/browse/IDP-1872?atlOrigin=eyJpIjoiMGNmMGUwM2YzNjYyNDVjNmE4MDg3NGE4NGU3NWRmYWQiLCJwIjoiaiJ9 )

From a server point of view you cannot see which domain set the cookie. It just receives the key-value pair in the request header.

Lets say you host your idp at idp.example.com ( http://idp.example.com )

If someone at whatever.example.com ( http://whatever.example.com ) sets a cookie “_idp_spnego_autologin=1; domain=example.com ( http://domain=example.com ) ”, this cookie will be send to idp.example.com ( http://idp.example.com ) to trigger the SPNEGO login behaviour in this case.

By using the __Host- prefix, you can rest asure that the cookie is set on the host itself (and secure) and not by a host that shares the common domain.

I could scope this issue to the SPNEGO module, but I think it would be a best practice that all cookies are __Host- prefixed that can alter the IdP’s behaviour.

( https://shibboleth.atlassian.net/browse/IDP-1872#add-comment?atlOrigin=eyJpIjoiMGNmMGUwM2YzNjYyNDVjNmE4MDg3NGE4NGU3NWRmYWQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1872#add-comment?atlOrigin=eyJpIjoiMGNmMGUwM2YzNjYyNDVjNmE4MDg3NGE4NGU3NWRmYWQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100183- sha1:51e3c50 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20211022/decc4cdb/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-602f57b1-084f-4ce5-b665-7264c322fb35
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211022/decc4cdb/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-9c30f295-fe7f-4cb4-aa03-3a1d47a33293
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211022/decc4cdb/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-b4c7ab2b-3284-4771-8cfb-c601b3b3cf71
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211022/decc4cdb/attachment-0005.png>