[cpp-log4shib] 02/04: Simplify C(XX)FLAGS handling

Scott Cantor cantor.2 at osu.edu
Tue Oct 19 14:55:31 UTC 2021


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository cpp-log4shib.

View the commit online:
http://git.shibboleth.net/view/?p=cpp-log4shib.git;a=commit;h=c946440d8a08d3d60a4d56033be15e9f2b6ca410

commit c946440d8a08d3d60a4d56033be15e9f2b6ca410
Author: Ferenc Wágner <wferi at debian.org>
AuthorDate: Sat Nov 24 15:57:59 2018 +0100

    Simplify C(XX)FLAGS handling
    
    Leave the default at -g -O2 as AC_PROG_CC sets it; such options are
    better customized by setting C(XX)FLAGS on the command line.
    Defining NDEBUG is risky, don't do that; use --enable-debug for
    producing the debug variant only (which is identical to the normal
    variant at the moment).
---
 configure.ac | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/configure.ac b/configure.ac
index c2912a0..49dae10 100644
--- a/configure.ac
+++ b/configure.ac
@@ -31,15 +31,12 @@ AC_ARG_WITH(idsa, AS_HELP_STRING(--with-idsa, [include idsa support]),)
 AC_CANONICAL_HOST
 
 AC_ARG_ENABLE(debug,
-    AS_HELP_STRING(--enable-debug, [Have GCC compile with symbols (Default = no)]),
+    AS_HELP_STRING(--enable-debug, [Produce debug variant (Default = no)]),
     enable_debug=$enableval, enable_debug=no)
 
 if test "$enable_debug" = "yes" ; then
-    AM_CFLAGS="-g -D_DEBUG"
-    AM_CXXFLAGS="-g -D_DEBUG"
-else
-    AM_CFLAGS="-O2 -DNDEBUG"
-    AM_CXXFLAGS="-O2 -DNDEBUG"
+    AM_CFLAGS="-D_DEBUG"
+    AM_CXXFLAGS="-D_DEBUG"
 fi
 
 LT_INIT([disable-static])

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list