[JIRA] (IDP-1868) Attribute-based subject c14n is mishandling Scoped values

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *created* an issue

Identity Provider ( https://shibboleth.atlassian.net/browse/IDP?atlOrigin=eyJpIjoiYThmODhjMmVmNDdhNDBhMGI2YWY2MDM4MGJiOWMyMmIiLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/IDP-1868?atlOrigin=eyJpIjoiYThmODhjMmVmNDdhNDBhMGI2YWY2MDM4MGJiOWMyMmIiLCJwIjoiaiJ9 ) IDP-1868 ( https://shibboleth.atlassian.net/browse/IDP-1868?atlOrigin=eyJpIjoiYThmODhjMmVmNDdhNDBhMGI2YWY2MDM4MGJiOWMyMmIiLCJwIjoiaiJ9 ) Attribute-based subject c14n is mishandling Scoped values ( https://shibboleth.atlassian.net/browse/IDP-1868?atlOrigin=eyJpIjoiYThmODhjMmVmNDdhNDBhMGI2YWY2MDM4MGJiOWMyMmIiLCJwIjoiaiJ9 )

Issue Type: Bug Affects Versions: 4.0.0, 4.0.1, 4.1.0, 4.1.1, 4.1.2, 4.1.3, 4.1.4 Assignee: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) Components: Subject Canonicalization Created: 12/Oct/21 1:56 PM Fix Versions: 4.2.0 Priority: Trivial Reporter: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 )

I think this broke because of a change in 4.0 perhaps, but may have been broken all along. The conditions that check for AttributeValue type are sequenced such that it checks String before Scoped, and since Scoped is a subclass it never gets there.

If they weren't direct parent/child before, this might be a regression in 4.0.

The impact is, e.g., if you c14n against EPPN, you get the value, and not value at scope. Very noticeable in proxying.

( https://shibboleth.atlassian.net/browse/IDP-1868#add-comment?atlOrigin=eyJpIjoiYThmODhjMmVmNDdhNDBhMGI2YWY2MDM4MGJiOWMyMmIiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1868#add-comment?atlOrigin=eyJpIjoiYThmODhjMmVmNDdhNDBhMGI2YWY2MDM4MGJiOWMyMmIiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100181- sha1:c5b808b )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20211012/7d09bc16/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-cc72467c-330d-4f9b-a896-816b1362c882
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211012/7d09bc16/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-24a9489e-d5db-4339-bcc0-52ece90491e8
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211012/7d09bc16/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-7c8faef4-0535-4251-a10b-5892e300d20f
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211012/7d09bc16/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-03b6067f-e32c-4b1b-bfa7-bc51668c94c8
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211012/7d09bc16/attachment-0007.png>