[java-mvn-enforcer] 05/05: JPAR-190 Investigate an enforcer to check all jars and poms ~/.m2/.... towards the end of a build

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-mvn-enforcer.

View the commit online:
http://git.shibboleth.net/view/?p=java-mvn-enforcer.git;a=commit;h=544898a6737bef3ff2600cb103310869819dcd99

commit 544898a6737bef3ff2600cb103310869819dcd99
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Sun Oct 10 13:42:05 2021 +0100

    JPAR-190 Investigate an enforcer to check all jars and poms ~/.m2/.... towards the end of a build
    
    https://shibboleth.atlassian.net/browse/JPAR-190
    
    Cleanup logging.
      - Only issue an ERROR if this will stop the enforcer,
      - Make sure that all failures are logged at ERROR
---
 .../java/net/shibboleth/mvn/enforcer/impl/BaseSigChecker.java     | 8 ++++----
 src/main/java/net/shibboleth/mvn/enforcer/impl/JarEnforcer.java   | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/main/java/net/shibboleth/mvn/enforcer/impl/BaseSigChecker.java b/src/main/java/net/shibboleth/mvn/enforcer/impl/BaseSigChecker.java
index caeac46..f306b70 100644
--- a/src/main/java/net/shibboleth/mvn/enforcer/impl/BaseSigChecker.java
+++ b/src/main/java/net/shibboleth/mvn/enforcer/impl/BaseSigChecker.java
@@ -111,19 +111,19 @@ public class BaseSigChecker {
         final GPGKeyRing keyRing = getKeyRing(group);
         if (keyRing == null) {
             report.format("%-30s: %-14s No keyring for group %s\n", id, version, group);
-            log.info("{} {} no keyring for group",  id, version, group);
+            log.error("{} {} no keyring for group",  id, version, group);
             return false;
         }
         final Signature sig = getSignature(artifact);
         if (sig == null) {
             report.format("%-30s: %-14s Could not find signature (group : %s)\n", id, version, group);
-            log.info("{} {} could not find signature (group={})", id, version, group);
+            log.error("{} {} could not find signature (group={})", id, version, group);
             return false;
         }
         if (!keyRing.contains(sig)) {
             report.format("%-30s: %-14s KeyId (%s) not found in keyring for %s\n",
                     id, version, sig.toString(), group);
-            log.info("{} {} KeyId ({}) not found in keyring for {}",
+            log.error("{} {} KeyId ({}) not found in keyring for {}",
                     id, version, sig.toString(), group);
             return false;
         }
@@ -132,7 +132,7 @@ public class BaseSigChecker {
             if (!keyRing.checkSignature(stream, sig)) {
                 report.format("%-30s: %-14s Signature Mismatch : %s in keyring %s\n",
                         id, version, keyRing.getKeyInfo(sig), group);
-                log.info("{} {} Signature Mismatch : ({}) in keyring for {}",
+                log.error("{} {} Signature Mismatch : ({}) in keyring for {}",
                         id, version, sig.toString(), group);
                 return false;
             }
diff --git a/src/main/java/net/shibboleth/mvn/enforcer/impl/JarEnforcer.java b/src/main/java/net/shibboleth/mvn/enforcer/impl/JarEnforcer.java
index 4a30f30..ba767aa 100644
--- a/src/main/java/net/shibboleth/mvn/enforcer/impl/JarEnforcer.java
+++ b/src/main/java/net/shibboleth/mvn/enforcer/impl/JarEnforcer.java
@@ -284,7 +284,7 @@ public class JarEnforcer implements EnforcerRule, MavenLoader{
                 log.debug("Resolved OK :" + artifact.toString() + ":" + type);
                 return mavenArtifact.getFile().toPath();
             }
-            log.error("Could not resolve " + artifact.toString() + ":" + type);
+            log.info("Could not resolve " + artifact.toString() + ":" + type);
         }
         return null;
     }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.