[JIRA] (IDP-1866) Module handling does not work when idpHome is classpath:
Rod Widdowson (Jira)
jira at shibboleth.atlassian.net
Wed Oct 6 15:01:53 UTC 2021
Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on IDP-1866 ( https://shibboleth.atlassian.net/browse/IDP-1866?atlOrigin=eyJpIjoiYTNjYWUyZjY2YjY5NDdlNDgxNGJiOWJjMmFlZjU1MzEiLCJwIjoiaiJ9 )
Re: Module handling does not work when idpHome is classpath: ( https://shibboleth.atlassian.net/browse/IDP-1866?atlOrigin=eyJpIjoiYTNjYWUyZjY2YjY5NDdlNDgxNGJiOWJjMmFlZjU1MzEiLCJwIjoiaiJ9 )
ModuleContext is a final class so we can add methods to it (and fix the base module class). But I do not see how we can fix this in 4.2 without breaking the API contract
@Nonnull Path getIdPHome() {
I suppose we could just return Path.of("") Nothing that works now will stop working.
( https://shibboleth.atlassian.net/browse/IDP-1866#add-comment?atlOrigin=eyJpIjoiYTNjYWUyZjY2YjY5NDdlNDgxNGJiOWJjMmFlZjU1MzEiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1866#add-comment?atlOrigin=eyJpIjoiYTNjYWUyZjY2YjY5NDdlNDgxNGJiOWJjMmFlZjU1MzEiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100180- sha1:6623038 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20211006/f4be633c/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-f0286ece-69ab-4460-8d12-442a64af5ab1
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211006/f4be633c/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-a7f5ab1f-075f-408a-b073-2e1ca188a040
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211006/f4be633c/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-736f23a0-d2ae-4770-9325-3cac15f19472
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211006/f4be633c/attachment-0005.png>
More information about the commits
mailing list