[JIRA] (IDP-1864) Jetty and the IdP have to be in sync on logging versions

Scott Cantor (Jira) jira at shibboleth.atlassian.net
Tue Oct 5 20:48:25 UTC 2021


Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *created* an issue

Identity Provider ( https://shibboleth.atlassian.net/browse/IDP?atlOrigin=eyJpIjoiYWVkNWQzNjc0Njk4NDI0M2I1MzM5NjMwMDI5MGFjZDEiLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/IDP-1864?atlOrigin=eyJpIjoiYWVkNWQzNjc0Njk4NDI0M2I1MzM5NjMwMDI5MGFjZDEiLCJwIjoiaiJ9 ) IDP-1864 ( https://shibboleth.atlassian.net/browse/IDP-1864?atlOrigin=eyJpIjoiYWVkNWQzNjc0Njk4NDI0M2I1MzM5NjMwMDI5MGFjZDEiLCJwIjoiaiJ9 ) Jetty and the IdP have to be in sync on logging versions ( https://shibboleth.atlassian.net/browse/IDP-1864?atlOrigin=eyJpIjoiYWVkNWQzNjc0Njk4NDI0M2I1MzM5NjMwMDI5MGFjZDEiLCJwIjoiaiJ9 )

Issue Type: Bug Affects Versions: 4.0.0, 4.0.1, 4.1.0, 4.1.1, 4.1.2, 4.1.3, 4.1.4 Assignee: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) Components: Logging and Metrics, MSI Installer Created: 05/Oct/21 4:48 PM Fix Versions: 4.2.0 Priority: Trivial Reporter: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 )

Not sure I know the right answer but we currently have sort of floating assumption that the deployer must be matching the versions of slf4j and logback between the shipped IdP and the Jetty layer if using the idp-logging module example or the underlying Jetty modules that use those jars.

This isn't really clean because upgrading either IdP or Jetty can break or become a source of conflict if they don't match. This is a general Jetty upgrade issue anyway I guess, so maybe the answer is "be careful, document" while dealing with it in the obvious way in our Jetty packaging for Windows.

We can force Jetty to use the versions we package by setting variables in the ini file (e.g. logback.version=1.2.3). That seems to get Jetty to start up properly on the older logback in 9.4.44. Maybe that's the right answer.

That might be the extent of the work I guess, modulo maybe adding to the Jetty example docs and the jetty-base example repo such that it matches what we're shipping.

Ultimately I guess this is just a thing we have to be conscious of.

( https://shibboleth.atlassian.net/browse/IDP-1864#add-comment?atlOrigin=eyJpIjoiYWVkNWQzNjc0Njk4NDI0M2I1MzM5NjMwMDI5MGFjZDEiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1864#add-comment?atlOrigin=eyJpIjoiYWVkNWQzNjc0Njk4NDI0M2I1MzM5NjMwMDI5MGFjZDEiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100179- sha1:b2eb7ec )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20211005/68ee4f7a/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-0ca0cf65-85ad-4a6d-afde-ae7570b5633f
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211005/68ee4f7a/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-0f1b0257-4047-4d92-8eaa-b97780b432f4
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211005/68ee4f7a/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-16460c46-b4ce-47b8-b828-82f7faca3def
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211005/68ee4f7a/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-010d40dd-2ae2-421c-8c47-067907cdf40c
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211005/68ee4f7a/attachment-0007.png>


More information about the commits mailing list