[cpp-sp] 01/03: Strip NO_START functionality from the init script

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository cpp-sp.

View the commit online:
http://git.shibboleth.net/view/?p=cpp-sp.git;a=commit;h=5ae599583168d026928e943d4392ace99546eb87

commit 5ae599583168d026928e943d4392ace99546eb87
Author: Ferenc Wágner <wferi at debian.org>
AuthorDate: Wed Apr 29 16:09:50 2020 +0200

    Strip NO_START functionality from the init script
    
    Quoting Lintian:
    
    This is an older practice used so that the package's init script would
    not start the service until the local system administrator changed this
    value.
    
    However, this hides from the underlying init system whether or not the
    daemon should actually be started leading to confusing behavior
    including "service package start" returning success without the service
    actually starting.
---
 configs/shibd-debian.in | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/configs/shibd-debian.in b/configs/shibd-debian.in
index 9f7e3bdf..92bb232b 100644
--- a/configs/shibd-debian.in
+++ b/configs/shibd-debian.in
@@ -121,13 +121,6 @@ case "$1" in
 start)
     prepare_environment
 
-    # Don't start shibd if NO_START is set.
-    if [ "$NO_START" = 1 ] ; then
-        if [ "$VERBOSE" != no ] ; then
-            echo "Not starting $DESC (see /etc/default/$NAME)"
-        fi
-        exit 0
-    fi
     [ "$VERBOSE" != no ] && log_daemon_msg "Starting $DESC" "$NAME"
     do_start
     case "$?" in

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.