[JIRA] (SSPCPP-947) Windows Installer should force rebuild the MSMs

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on SSPCPP-947 ( https://shibboleth.atlassian.net/browse/SSPCPP-947?atlOrigin=eyJpIjoiMTVlMGZhNjY2MDM2NDdjZWFlNGRlMGFhOGEyMDM0ZDAiLCJwIjoiaiJ9 )

Re: Windows Installer should force rebuild the MSMs ( https://shibboleth.atlassian.net/browse/SSPCPP-947?atlOrigin=eyJpIjoiMTVlMGZhNjY2MDM2NDdjZWFlNGRlMGFhOGEyMDM0ZDAiLCJwIjoiaiJ9 )

This is all a bit byzantine. The top level make file calls the installer vcxproject which calls another make file.

I suspect that a correct fix would involve removing the vcxproj from the whole process and call nmake recusively as appropriate, But given where we are in the lifecycle of this project I am included to just do as we discussed and change the targets in build.make from

msi32: exe32 mergemodules32 msi32only

msi64: exe64 mergemodules64 exe32 mergemodules32 msi64only

to

msi32: exe32 cleanmergemodules32 mergemodules32 msi32only

msi64: exe64 cleanmergemodules64 mergemodules64 exe32 mergemodules32 msi64only

cleanmergemodules32:
 del /s $(SPROOT)\msi\WiX\MergeModules *-x86.wixobj *-x86.msm *-x86.wixpdb
 
cleanmergemodules64:
 del /s $(SPROOT)\msi\WiX\MergeModules *-x64.wixobj *-x64.msm *-x64.wixpdb

Which might burn a few cycles but cost a lot less engineer times.

I’m going to leave this idea to mature for a little bit before I commit it.

( https://shibboleth.atlassian.net/browse/SSPCPP-947#add-comment?atlOrigin=eyJpIjoiMTVlMGZhNjY2MDM2NDdjZWFlNGRlMGFhOGEyMDM0ZDAiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/SSPCPP-947#add-comment?atlOrigin=eyJpIjoiMTVlMGZhNjY2MDM2NDdjZWFlNGRlMGFhOGEyMDM0ZDAiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100183- sha1:8cd14d0 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20211124/072ae158/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-32858c20-eb38-426d-86dc-6145a11f07d9
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211124/072ae158/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-c1c8c36f-25d1-4e6d-bf3b-703577432aaf
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211124/072ae158/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-bd09a929-dfef-435b-93da-841c8f6f7f20
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211124/072ae158/attachment-0005.png>