[java-identity-provider] branch main updated: IDP-1817 Move extraction of display information from Attribute Resolution to point of use

Rod Widdowson rdw at steadingsoftware.com
Wed Nov 17 17:13:41 UTC 2021


This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=03115c9df7e849c0301e161aced462b7e3676b46

The following commit(s) were added to refs/heads/main by this push:
     new 03115c9df IDP-1817 Move extraction of display information from Attribute Resolution to point of use
03115c9df is described below

commit 03115c9df7e849c0301e161aced462b7e3676b46
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Wed Nov 17 17:12:37 2021 +0000

    IDP-1817 Move extraction of display information from Attribute Resolution to point of use
    
    https://shibboleth.atlassian.net/browse/IDP-1817
    
    Stop adding display and description into to attributed when the transcoder
    is decoding them.
    
    These days this gets added at point of use and adding it too soon will
    provoke deprecation warnings
---
 .../idp/attribute/transcoding/AbstractAttributeTranscoder.java       | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/transcoding/AbstractAttributeTranscoder.java b/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/transcoding/AbstractAttributeTranscoder.java
index a8c57cb00..66c725b66 100644
--- a/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/transcoding/AbstractAttributeTranscoder.java
+++ b/idp-attribute-api/src/main/java/net/shibboleth/idp/attribute/transcoding/AbstractAttributeTranscoder.java
@@ -79,6 +79,7 @@ public abstract class AbstractAttributeTranscoder<T> extends AbstractInitializab
         return doEncode(profileRequestContext, attribute, to, rule);
     }
     
+   
     /** {@inheritDoc} */
     @Nullable public IdPAttribute decode(@Nullable final ProfileRequestContext profileRequestContext,
             @Nonnull final T input, @Nonnull final TranscodingRule rule) throws AttributeDecodingException {
@@ -90,10 +91,6 @@ public abstract class AbstractAttributeTranscoder<T> extends AbstractInitializab
         }
         
         final IdPAttribute attribute = doDecode(profileRequestContext, input, rule);
-        
-        attribute.setDisplayNames(rule.getDisplayNames());
-        attribute.setDisplayDescriptions(rule.getDescriptions());
-        
         return attribute;
     }
     

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list