[JIRA] (IDP-1810) Extend ModuleContext to accumulate enabled/disabled state

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on IDP-1810 ( https://shibboleth.atlassian.net/browse/IDP-1810?atlOrigin=eyJpIjoiZmVkYzExM2Y2Y2VjNDNkM2FkY2UxZmUwOTlkZDYxNDAiLCJwIjoiaiJ9 )

Re: Extend ModuleContext to accumulate enabled/disabled state ( https://shibboleth.atlassian.net/browse/IDP-1810?atlOrigin=eyJpIjoiZmVkYzExM2Y2Y2VjNDNkM2FkY2UxZmUwOTlkZDYxNDAiLCJwIjoiaiJ9 )

Let me explain the need by describing what the plugin installer does.

The installer will issue a series (or no) Module enables and disables during its operation and at the end it wants to summarize what happened.

In the ‘module’ command this is done by immediately spitting out the return value from the #enable(...) or #disable(...) method (which is a Map<ModuleResource,ResourceResult>.

The Installer cannot not emit at point of operation because there is other stuff happening and so it basically keeps a Map<ModuleResource,ResourceResult> of its own and accumulates the result of the operations in there.   This is output at the end.

The idea here was that the ModuleContext would be a great place to accumulate this information, nothing more than that.

I didn’t just do it because the architecture of it might jar on you and you might prefer the solution of accumulating the results external to the Context.

( https://shibboleth.atlassian.net/browse/IDP-1810#add-comment?atlOrigin=eyJpIjoiZmVkYzExM2Y2Y2VjNDNkM2FkY2UxZmUwOTlkZDYxNDAiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1810#add-comment?atlOrigin=eyJpIjoiZmVkYzExM2Y2Y2VjNDNkM2FkY2UxZmUwOTlkZDYxNDAiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100183- sha1:8e458bc )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20211103/faac4374/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-333e2495-ff74-454a-b7bc-fbf8792da825
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211103/faac4374/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-4d47b4d3-d0b5-4c62-bc02-1c5432c3bafe
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211103/faac4374/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-ded0b3ca-db4c-47df-98f5-a818f11dbec5
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211103/faac4374/attachment-0005.png>