[java-identity-provider] branch main updated: IDP-1851 - reduce inappropriate error logging from supports() functions

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=384dfcc73fb1ec395c67f3f09267cc991133da16

The following commit(s) were added to refs/heads/main by this push:
     new 384dfcc73 IDP-1851 - reduce inappropriate error logging from supports() functions
384dfcc73 is described below

commit 384dfcc73fb1ec395c67f3f09267cc991133da16
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Wed Nov 3 08:31:17 2021 -0400

    IDP-1851 - reduce inappropriate error logging from supports() functions
    
    https://shibboleth.atlassian.net/browse/IDP-1851
---
 .../idp/authn/principal/SealedPrincipalSerializer.java      | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/idp-authn-api/src/main/java/net/shibboleth/idp/authn/principal/SealedPrincipalSerializer.java b/idp-authn-api/src/main/java/net/shibboleth/idp/authn/principal/SealedPrincipalSerializer.java
index 90946d954..263e83f7a 100644
--- a/idp-authn-api/src/main/java/net/shibboleth/idp/authn/principal/SealedPrincipalSerializer.java
+++ b/idp-authn-api/src/main/java/net/shibboleth/idp/authn/principal/SealedPrincipalSerializer.java
@@ -81,21 +81,26 @@ public class SealedPrincipalSerializer<T extends Principal> extends SimplePrinci
     /** {@inheritDoc} */
     @Override
     public boolean supports(@Nonnull final Principal principal) {
-        if (sealer == null) {
+        if (!super.supports(principal)) {
+            return false;
+        } else if (sealer == null) {
             log.error("No DataSealer was provided, unable to support serialization");
             return false;
         }
-        return super.supports(principal);
+        return true;
     }
 
     /** {@inheritDoc} */
     @Override
     public boolean supports(@Nonnull @NotEmpty final String value) {
-        if (sealer == null) {
+
+        if (!super.supports(value)) {
+            return false;
+        } else if (sealer == null) {
             log.error("No DataSealer was provided, unable to support deserialization");
             return false;
         }
-        return super.supports(value);
+        return true;
     }
     
     /** {@inheritDoc} */

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.