[java-idp-plugin-duo] branch main updated: JCOMOIDC-20 - Add clockskew to authentication time check

Phil Smart philip.smart at jisc.ac.uk
Fri May 21 16:09:42 UTC 2021


This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-duo.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-duo.git;a=commit;h=9da63a02a9e66af73424d24e19adb34baea1a790

The following commit(s) were added to refs/heads/main by this push:
       new  9da63a0   JCOMOIDC-20 - Add clockskew to authentication time check
9da63a0 is described below

commit 9da63a02a9e66af73424d24e19adb34baea1a790
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Fri May 21 17:09:40 2021 +0100

    JCOMOIDC-20 - Add clockskew to authentication time check
    
    exposed clockskew setting in flow beans using the standard jwt verifier
    property idp.duo.oidc.jwt.verifier.clockSkew
    
    https://issues.shibboleth.net/jira/browse/JCOMOIDC-20
---
 .../idp/plugin/authn/duo/AbstractDuoAuthenticationAction.java           | 2 +-
 .../net/shibboleth/idp/flows/authn/DuoOIDC/duo-oidc-authn-beans.xml     | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/idp-duo-api/src/main/java/net/shibboleth/idp/plugin/authn/duo/AbstractDuoAuthenticationAction.java b/idp-duo-api/src/main/java/net/shibboleth/idp/plugin/authn/duo/AbstractDuoAuthenticationAction.java
index adb4874..d239983 100644
--- a/idp-duo-api/src/main/java/net/shibboleth/idp/plugin/authn/duo/AbstractDuoAuthenticationAction.java
+++ b/idp-duo-api/src/main/java/net/shibboleth/idp/plugin/authn/duo/AbstractDuoAuthenticationAction.java
@@ -133,7 +133,7 @@ public abstract class AbstractDuoAuthenticationAction extends AbstractAuthentica
     }
     
     /**
-     * Performs this Duo authentication action using the supplied Duo client. Implementations
+     * Performs this Duo authentication action using the supplied Duo context. Implementations
      * should override this method.
      * 
      * @param profileRequestContext the current IdP profile request context
diff --git a/idp-duo-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/DuoOIDC/duo-oidc-authn-beans.xml b/idp-duo-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/DuoOIDC/duo-oidc-authn-beans.xml
index 5d87770..a61643f 100644
--- a/idp-duo-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/DuoOIDC/duo-oidc-authn-beans.xml
+++ b/idp-duo-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/DuoOIDC/duo-oidc-authn-beans.xml
@@ -178,6 +178,7 @@
              <bean id="authenticationTimeClaimValidator" 
                 class="net.shibboleth.oidc.security.jwt.claims.impl.AuthenticationTimeClaimsValidator"
                 p:authnLifetime="%{idp.duo.oidc.jwt.verifier.authLifetime:PT60S}"
+                p:clockSkew="%{idp.duo.oidc.jwt.verifier.clockSkew:PT60S}"
                 p:activationCondition="#{getObject('shibboleth.authn.DuoOIDC.jwt.AuthTimeActivationCondition') ?: 
                                 getObject('shibboleth.authn.DuoOIDC.jwt.DefaultAuthTimeActivationCondition')}"/>
              <bean id="nonceClaimValidator" 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list