[java-identity-provider] 01/02: IDP-1770 Installer is disabling modules during plugin upgrade

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=1451429192821c900813467078c2d842bcfecc18

commit 1451429192821c900813467078c2d842bcfecc18
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Tue Mar 9 10:58:33 2021 +0000

    IDP-1770 Installer is disabling modules during plugin upgrade
    
    https://issues.shibboleth.net/jira/browse/IDP-1770
---
 .../idp/installer/plugin/impl/PluginInstaller.java     | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/idp-installer/src/main/java/net/shibboleth/idp/installer/plugin/impl/PluginInstaller.java b/idp-installer/src/main/java/net/shibboleth/idp/installer/plugin/impl/PluginInstaller.java
index e5f88c851..84c257493 100644
--- a/idp-installer/src/main/java/net/shibboleth/idp/installer/plugin/impl/PluginInstaller.java
+++ b/idp-installer/src/main/java/net/shibboleth/idp/installer/plugin/impl/PluginInstaller.java
@@ -460,24 +460,6 @@ public final class PluginInstaller extends AbstractInitializableComponent implem
      * @param rollback Rollback Context
      * @throws BuildException on IO or module errors */
     private void uninstallOld(final RollbackPluginInstall rollback) throws BuildException {
-        final IdPPlugin oldPlugin = getInstalledPlugin(pluginId);
-        if (oldPlugin == null) {
-            LOG.debug("{} not installed. No modules disabled", pluginId);
-        } else {
-            String moduleId = null;
-            try {
-                for (final IdPModule module: oldPlugin.getDisableOnRemoval()) {
-                    moduleId = module.getId();
-                    if (module.isEnabled(moduleContext)) {
-                        module.disable(moduleContext, false);
-                        rollback.getModulesDisabled().add(module);
-                    }
-                }
-            } catch (final ModuleException e) {
-                LOG.error("Error disabling {}", moduleId);
-                throw new BuildException(e);
-            }
-        }
 
         if (getVersionFromContents() == null) {
             LOG.debug("{} not installed. files renamed", pluginId);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.