[java-identity-provider] branch main updated: IDP-1767 - Missing username/password doesn't trigger classified error

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=346b6acce2a396c5a6a7fa9d4b963a12ffd67aa5

The following commit(s) were added to refs/heads/main by this push:
       new  346b6acce IDP-1767 - Missing username/password doesn't trigger classified error
346b6acce is described below

commit 346b6acce2a396c5a6a7fa9d4b963a12ffd67aa5
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Mon Mar 8 09:31:34 2021 -0500

    IDP-1767 - Missing username/password doesn't trigger classified error
    
    https://issues.shibboleth.net/jira/browse/IDP-1767
---
 .../idp/authn/AbstractUsernamePasswordCredentialValidator.java    | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/idp-authn-api/src/main/java/net/shibboleth/idp/authn/AbstractUsernamePasswordCredentialValidator.java b/idp-authn-api/src/main/java/net/shibboleth/idp/authn/AbstractUsernamePasswordCredentialValidator.java
index 576b8d53b..a0fcbe640 100644
--- a/idp-authn-api/src/main/java/net/shibboleth/idp/authn/AbstractUsernamePasswordCredentialValidator.java
+++ b/idp-authn-api/src/main/java/net/shibboleth/idp/authn/AbstractUsernamePasswordCredentialValidator.java
@@ -240,22 +240,22 @@ public abstract class AbstractUsernamePasswordCredentialValidator extends Abstra
         if (upContext == null) {
             log.info("{} No UsernamePasswordContext available", getLogPrefix());
             if (errorHandler != null) {
-                errorHandler.handleError(profileRequestContext, authenticationContext, (String) null,
+                errorHandler.handleError(profileRequestContext, authenticationContext, AuthnEventIds.NO_CREDENTIALS,
                         AuthnEventIds.NO_CREDENTIALS);
             }
             throw new LoginException(AuthnEventIds.NO_CREDENTIALS);
         } else if (upContext.getUsername() == null) {
             log.info("{} No username available within UsernamePasswordContext", getLogPrefix());
             if (errorHandler != null) {
-                errorHandler.handleError(profileRequestContext, authenticationContext, (String) null,
+                errorHandler.handleError(profileRequestContext, authenticationContext, AuthnEventIds.NO_CREDENTIALS,
                         AuthnEventIds.NO_CREDENTIALS);
             }
             throw new LoginException(AuthnEventIds.NO_CREDENTIALS);
         } else if (upContext.getPassword() == null) {
             log.info("{} No password available within UsernamePasswordContext", getLogPrefix());
             if (errorHandler != null) {
-                errorHandler.handleError(profileRequestContext, authenticationContext, (String) null,
-                        AuthnEventIds.INVALID_CREDENTIALS);
+                errorHandler.handleError(profileRequestContext, authenticationContext,
+                        AuthnEventIds.INVALID_CREDENTIALS, AuthnEventIds.INVALID_CREDENTIALS);
             }
             throw new LoginException(AuthnEventIds.INVALID_CREDENTIALS);
         }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.