[java-oidc-common] branch main updated: JCOMOIDC-15 - Metadata node processor fails on multiple Extensions

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-oidc-common.

View the commit online:
http://git.shibboleth.net/view/?p=java-oidc-common.git;a=commit;h=2a502b164730012fff0b23e9d8d1a858e509d8d4

The following commit(s) were added to refs/heads/main by this push:
       new  2a502b1   JCOMOIDC-15 - Metadata node processor fails on multiple Extensions
2a502b1 is described below

commit 2a502b164730012fff0b23e9d8d1a858e509d8d4
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Tue Mar 2 14:53:45 2021 -0500

    JCOMOIDC-15 - Metadata node processor fails on multiple Extensions
    
    https://issues.shibboleth.net/jira/browse/JCOMOIDC-15
---
 .../oidc/metadata/impl/ClientInformationNodeProcessor.java | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/oidc-common-metadata-impl/src/main/java/net/shibboleth/oidc/metadata/impl/ClientInformationNodeProcessor.java b/oidc-common-metadata-impl/src/main/java/net/shibboleth/oidc/metadata/impl/ClientInformationNodeProcessor.java
index 1ae17dc..eef15fd 100644
--- a/oidc-common-metadata-impl/src/main/java/net/shibboleth/oidc/metadata/impl/ClientInformationNodeProcessor.java
+++ b/oidc-common-metadata-impl/src/main/java/net/shibboleth/oidc/metadata/impl/ClientInformationNodeProcessor.java
@@ -122,8 +122,6 @@ public class ClientInformationNodeProcessor implements MetadataNodeProcessor {
                         new OIDCClientInformation(clientId, null, metadata, clientSecret);
                 metadataNode.getObjectMetadata().put(clientInformation);
             }
-        } else {
-            log.trace("Ignoring object {}", metadataNode);
         }
     }
 
@@ -211,7 +209,7 @@ public class ClientInformationNodeProcessor implements MetadataNodeProcessor {
             metadata.setJWKSet(parseJwkSet(credentials, clientId));
            
         } else {
-            log.debug("No OAuthRPExtensions found to be processed");
+            log.debug("No {} found to be processed", OAuthRPExtensions.TYPE_LOCAL_NAME);
         }
         return metadata;
     }
@@ -228,19 +226,19 @@ public class ClientInformationNodeProcessor implements MetadataNodeProcessor {
             log.debug("No extensions found from the given SPSSODescriptor");
             return null;
         }
-        final List<XMLObject> rpExtensions = extensions.getUnknownXMLObjects();
+        final List<XMLObject> rpExtensions = extensions.getUnknownXMLObjects(OAuthRPExtensions.TYPE_NAME);
         if (rpExtensions == null || rpExtensions.isEmpty()) {
-            log.debug("The extension element on SPSSODescriptor didn't have any child elements");
+            log.debug("SPSSODescriptor Extensions element had no {} child elements", OAuthRPExtensions.TYPE_LOCAL_NAME);
             return null;
         }
         if (rpExtensions.size() > 1) {
-            log.warn("More than one OAuthRPExtensions defined, using only one of them");
+            log.warn("More than one {} defined, using only one of them", OAuthRPExtensions.TYPE_LOCAL_NAME);
         }
         if (rpExtensions.get(0) instanceof OAuthRPExtensions) {
-            log.debug("Successfully parsed OAuthRPExtensions");
+            log.debug("Successfully parsed {}", OAuthRPExtensions.TYPE_LOCAL_NAME);
             return (OAuthRPExtensions) rpExtensions.get(0);
         }
-        log.warn("Could not parse OAuthRPExtensions from the element");
+        log.warn("Could not parse {} from the element", OAuthRPExtensions.TYPE_LOCAL_NAME);
         return null;
     }
     

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.