[cpp-sp] branch main updated: SSPCPP-940 - Template resolver plugin breaks on Unicode content in template

Scott Cantor cantor.2 at osu.edu
Fri Jul 30 13:49:24 UTC 2021


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository cpp-sp.

View the commit online:
http://git.shibboleth.net/view/?p=cpp-sp.git;a=commit;h=1fc712b1f0527e786d7edfe9258e650fd40ac48f

The following commit(s) were added to refs/heads/main by this push:
       new  1fc712b1  SSPCPP-940 - Template resolver plugin breaks on Unicode content in template
1fc712b1 is described below

commit 1fc712b1f0527e786d7edfe9258e650fd40ac48f
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Fri Jul 30 09:48:29 2021 -0400

    SSPCPP-940 - Template resolver plugin breaks on Unicode content in template
    
    https://issues.shibboleth.net/jira/browse/SSPCPP-940
---
 plugins/TemplateAttributeResolver.cpp | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/plugins/TemplateAttributeResolver.cpp b/plugins/TemplateAttributeResolver.cpp
index 81fa70a4..cfa84a7f 100644
--- a/plugins/TemplateAttributeResolver.cpp
+++ b/plugins/TemplateAttributeResolver.cpp
@@ -141,9 +141,10 @@ TemplateAttributeResolver::TemplateAttributeResolver(const DOMElement* e)
         throw ConfigurationException("Template AttributeResolver requires sources attribute.");
 
     e = e ? XMLHelper::getFirstChildElement(e, Template) : nullptr;
-    auto_ptr_char t(XMLHelper::getTextContent(e));
-    if (t.get()) {
-        m_template = t.get();
+    char* t = toUTF8(XMLHelper::getTextContent(e));
+    if (t) {
+        m_template = t;
+        delete[] t;
         trim(m_template);
     }
     if (m_template.empty())

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list