[java-idp-plugin-duo] branch main updated: Logging and property cleanup
Phil Smart
philip.smart at jisc.ac.uk
Fri Feb 26 11:03:23 UTC 2021
This is an automated email from the git hooks/post-receive script.
philsmart pushed a commit to branch main
in repository java-idp-plugin-duo.
View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-duo.git;a=commit;h=d1e6e59b4cf80686bd1bb27615be0f0ea45d849e
The following commit(s) were added to refs/heads/main by this push:
new d1e6e59 Logging and property cleanup
d1e6e59 is described below
commit d1e6e59b4cf80686bd1bb27615be0f0ea45d849e
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Fri Feb 26 11:03:20 2021 +0000
Logging and property cleanup
---
.../idp/plugin/authn/duo/DefaultDuoOIDCIntegration.java | 2 +-
.../plugin/authn/duo/impl/DefaultRedirectURICreationStrategy.java | 2 +-
.../idp/plugin/authn/duo/nimbus/conf/authn/duo-oidc.properties | 8 ++++----
.../idp/plugin/authn/duo/sdk/conf/authn/duo-oidc.properties | 8 ++++----
4 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/idp-duo-api/src/main/java/net/shibboleth/idp/plugin/authn/duo/DefaultDuoOIDCIntegration.java b/idp-duo-api/src/main/java/net/shibboleth/idp/plugin/authn/duo/DefaultDuoOIDCIntegration.java
index cf0d592..f925e99 100644
--- a/idp-duo-api/src/main/java/net/shibboleth/idp/plugin/authn/duo/DefaultDuoOIDCIntegration.java
+++ b/idp-duo-api/src/main/java/net/shibboleth/idp/plugin/authn/duo/DefaultDuoOIDCIntegration.java
@@ -222,7 +222,7 @@ public final class DefaultDuoOIDCIntegration extends AbstractInitializableCompon
Constraint.isNotEmpty(computedRedirectURI, "Computed redirect URI can not be null or empty");
if (redirectURI == null) {
- log.debug("Redirect_uri is being set on the first request as '{}'",computedRedirectURI);
+ log.debug("Redirect_uri is being set as '{}'",computedRedirectURI);
redirectURI = computedRedirectURI;
}
}
diff --git a/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/DefaultRedirectURICreationStrategy.java b/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/DefaultRedirectURICreationStrategy.java
index 44fef74..7d61ee1 100644
--- a/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/DefaultRedirectURICreationStrategy.java
+++ b/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/DefaultRedirectURICreationStrategy.java
@@ -76,7 +76,7 @@ public final class DefaultRedirectURICreationStrategy
final String redirectFromIntegration = integration.getRegisteredRedirectURI();
if (redirectFromIntegration != null) {
- log.trace("Using redirect_uri '{}' from the integration", redirectFromIntegration);
+ log.trace("Using redirect_uri '{}' from the Duo integration settings", redirectFromIntegration);
return redirectFromIntegration;
}
try {
diff --git a/idp-duo-nimbus-client-impl/src/main/resources/net/shibboleth/idp/plugin/authn/duo/nimbus/conf/authn/duo-oidc.properties b/idp-duo-nimbus-client-impl/src/main/resources/net/shibboleth/idp/plugin/authn/duo/nimbus/conf/authn/duo-oidc.properties
index e0c680f..174ef0f 100644
--- a/idp-duo-nimbus-client-impl/src/main/resources/net/shibboleth/idp/plugin/authn/duo/nimbus/conf/authn/duo-oidc.properties
+++ b/idp-duo-nimbus-client-impl/src/main/resources/net/shibboleth/idp/plugin/authn/duo/nimbus/conf/authn/duo-oidc.properties
@@ -16,16 +16,16 @@ idp.authn.DuoOIDC.supportedPrincipals = \
# Configure for your particular integration settings
idp.duo.oidc.apiHost = hostname
idp.duo.oidc.clientId = clientid
+# Static redirect_uri, comment out if you want to use a computed one, see below
idp.duo.oidc.redirectURL = https://<hostname>:<port>/idp/profile/Authn/Duo/2FA/duo-callback
+# We suggest defining this in credentials/secrets.properties
+#idp.duo.oidc.secretKey = key
# If a redirect_uri is not explicitly declared above, one can be inferred from each
# request's Host header. To avoid Host header injection attacks, the allowed origins
# must be specified here. Origins are comma seperated. Do not specify the port when
# using the default ports.
-# idp.duo.oidc.redirecturl.allowedOrigins = https://localhost
-
-# We suggest defining this in credentials/secrets.properties
-#idp.duo.oidc.secretKey = key
+#idp.duo.oidc.redirecturl.allowedOrigins = https://localhost
# Non-Browser AuthAPI integration if desired
#idp.duo.oidc.nonbrowser.apiHost = %{idp.duo.oidc.apiHost}
diff --git a/idp-duo-sdk-client-impl/src/main/resources/net/shibboleth/idp/plugin/authn/duo/sdk/conf/authn/duo-oidc.properties b/idp-duo-sdk-client-impl/src/main/resources/net/shibboleth/idp/plugin/authn/duo/sdk/conf/authn/duo-oidc.properties
index 880ee0c..75e6be6 100644
--- a/idp-duo-sdk-client-impl/src/main/resources/net/shibboleth/idp/plugin/authn/duo/sdk/conf/authn/duo-oidc.properties
+++ b/idp-duo-sdk-client-impl/src/main/resources/net/shibboleth/idp/plugin/authn/duo/sdk/conf/authn/duo-oidc.properties
@@ -16,16 +16,16 @@ idp.authn.DuoOIDC.supportedPrincipals = \
# Configure for your particular integration settings
idp.duo.oidc.apiHost = hostname
idp.duo.oidc.clientId = clientid
+# Static redirect_uri, comment out if you want to use a computed one, see below
idp.duo.oidc.redirectURL = https://<hostname>:<port>/idp/profile/Authn/Duo/2FA/duo-callback
+# We suggest defining this in credentials/secrets.properties
+#idp.duo.oidc.secretKey = key
# If a redirect_uri is not explicitly declared above, one can be inferred from the
# Host header of the 'first' request. To avoid Host header injection attacks, the
# allowed origins must be specified here. Origins are comma seperated. Do not specify
# the port when using default ports.
-# idp.duo.oidc.redirecturl.allowedOrigins = https://localhost
-
-# We suggest defining this in credentials/secrets.properties
-#idp.duo.oidc.secretKey = key
+#idp.duo.oidc.redirecturl.allowedOrigins = https://localhost
# Non-Browser AuthAPI integration if desired
#idp.duo.oidc.nonbrowser.apiHost = %{idp.duo.oidc.apiHost}
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the commits
mailing list