[java-oidc-common] branch main updated: Minor improvements to annotations and Javadoc

[Phil Smart]

This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-oidc-common.

View the commit online:
http://git.shibboleth.net/view/?p=java-oidc-common.git;a=commit;h=2cb54c3991ecc2f82343fa838957a21b83c767f0

The following commit(s) were added to refs/heads/main by this push:
       new  2cb54c3   Minor improvements to annotations and Javadoc
2cb54c3 is described below

commit 2cb54c3991ecc2f82343fa838957a21b83c767f0
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Wed Feb 24 17:10:49 2021 +0000

    Minor improvements to annotations and Javadoc
---
 .../net/shibboleth/oidc/jwt/claims/JWTClaimsValidation.java    |  1 +
 .../security/jwt/claims/impl/ChainingJWTClaimsValidation.java  | 10 ++++++----
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/oidc-common-crypto-api/src/main/java/net/shibboleth/oidc/jwt/claims/JWTClaimsValidation.java b/oidc-common-crypto-api/src/main/java/net/shibboleth/oidc/jwt/claims/JWTClaimsValidation.java
index a83079a..5d6204c 100644
--- a/oidc-common-crypto-api/src/main/java/net/shibboleth/oidc/jwt/claims/JWTClaimsValidation.java
+++ b/oidc-common-crypto-api/src/main/java/net/shibboleth/oidc/jwt/claims/JWTClaimsValidation.java
@@ -31,6 +31,7 @@ import com.nimbusds.jwt.JWTClaimsSet;
  *  <p>Does not have to be directly responsible for validating claims, can delegate to
  *  one or more {@link ClaimsValidator} implementations.</p>
  */
+//TODO is simply a function?
 public interface JWTClaimsValidation {
     
     /**
diff --git a/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/jwt/claims/impl/ChainingJWTClaimsValidation.java b/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/jwt/claims/impl/ChainingJWTClaimsValidation.java
index 9df96a9..3cea9fe 100644
--- a/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/jwt/claims/impl/ChainingJWTClaimsValidation.java
+++ b/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/jwt/claims/impl/ChainingJWTClaimsValidation.java
@@ -33,7 +33,9 @@ import com.nimbusds.jwt.JWTClaimsSet;
 import net.shibboleth.oidc.jwt.claims.ClaimsValidator;
 import net.shibboleth.oidc.jwt.claims.JWTClaimsValidation;
 import net.shibboleth.oidc.jwt.claims.JWTValidationException;
+import net.shibboleth.utilities.java.support.annotation.constraint.NonnullAfterInit;
 import net.shibboleth.utilities.java.support.annotation.constraint.NonnullElements;
+import net.shibboleth.utilities.java.support.annotation.constraint.ThreadSafeAfterInit;
 import net.shibboleth.utilities.java.support.component.AbstractInitializableComponent;
 import net.shibboleth.utilities.java.support.component.ComponentInitializationException;
 import net.shibboleth.utilities.java.support.component.ComponentSupport;
@@ -43,18 +45,18 @@ import net.shibboleth.utilities.java.support.component.ComponentSupport;
  * of configured validators. Validation terminates when one of the validators throws a {@link JWTValidationException}. 
  * If no {@link JWTValidationException} is thrown, the claims set is 'valid'.
  * 
- * <p>Note, does not represent a chain of responsibility pattern, despite the name.</p>
+ * <p>Note, does not represent a chain of responsibility pattern despite the name.</p>
  */
+ at ThreadSafeAfterInit
 public class ChainingJWTClaimsValidation extends AbstractInitializableComponent implements JWTClaimsValidation {
     
     /** Class logger. */
     @Nonnull private final Logger log = LoggerFactory.getLogger(ChainingJWTClaimsValidation.class);
     
     /** List of claim validators. Ordering is not important.*/
-    @Nonnull @NonnullElements private List<ClaimsValidator> claimValidators;
+    @NonnullAfterInit @NonnullElements private List<ClaimsValidator> claimValidators;
     
     
-    /** {@inheritDoc} */
     @Override
     protected void doInitialize() throws ComponentInitializationException {
         super.doInitialize();
@@ -84,7 +86,7 @@ public class ChainingJWTClaimsValidation extends AbstractInitializableComponent
         throws JWTValidationException {       
         
         if (claims == null) {
-            log.trace("No claims to verify, nothing todo");
+            log.trace("No claims to verify, nothing to do");
             return;
         }
         log.debug("Attempting JWT claims verification for subject '{}'",claims.getSubject());

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.