[java-idp-oidc] branch main updated: Removed unnecessary error-logging and improved Javadocs.

Henri Mikkonen henri.mikkonen at iki.fi
Fri Feb 19 08:29:31 UTC 2021


This is an automated email from the git hooks/post-receive script.

hjmikkon pushed a commit to branch main
in repository java-idp-oidc.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-oidc.git;a=commit;h=18cb0f6ea30f25467d35e9dc9808ec64222b1b1d

The following commit(s) were added to refs/heads/main by this push:
       new  18cb0f6e  Removed unnecessary error-logging and improved Javadocs.
18cb0f6e is described below

commit 18cb0f6ea30f25467d35e9dc9808ec64222b1b1d
Author: Henri Mikkonen <henri.mikkonen at iki.fi>
AuthorDate: Fri Feb 19 10:27:49 2021 +0200

    Removed unnecessary error-logging and improved Javadocs.
    
    Missing outboud message context is not an error in the cases when
    no error response message is sent back to an RP, but an error screen
    at the OP is shown.
---
 .../oidc/op/profile/impl/AbstractBuildErrorResponseFromEvent.java    | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/AbstractBuildErrorResponseFromEvent.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/AbstractBuildErrorResponseFromEvent.java
index cb4836b7..48d6d30a 100644
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/AbstractBuildErrorResponseFromEvent.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/AbstractBuildErrorResponseFromEvent.java
@@ -39,7 +39,8 @@ import net.shibboleth.utilities.java.support.logic.Constraint;
 
 /**
  * This action is extended by error response actions. Action reads an event from the configured {@link EventContext}
- * lookup strategy, constructs an OIDC error response message and attaches it as the outbound message.
+ * lookup strategy, constructs an OIDC error response message and attaches it as the outbound message, if outbound
+ * message context was found.
  * 
  * @param <T> ErrorResponse implementation.
  */
@@ -134,7 +135,7 @@ public abstract class AbstractBuildErrorResponseFromEvent<T extends ErrorRespons
         }
         
         if (profileRequestContext.getOutboundMessageContext() == null) {
-            log.error("{} No outbound message context initialized, nothing to do", getLogPrefix());
+            log.debug("{} No outbound message context initialized, nothing to do", getLogPrefix());
             return false;
         }
         

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list