[java-identity-provider] branch main updated: Plugin removal should not disable modules with the clean flag.

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=7f51a1e473558183209d81f80e1fc5e0329bb519

The following commit(s) were added to refs/heads/main by this push:
       new  7f51a1e47 Plugin removal should not disable modules with the clean flag.
7f51a1e47 is described below

commit 7f51a1e473558183209d81f80e1fc5e0329bb519
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Fri Feb 12 14:37:25 2021 -0500

    Plugin removal should not disable modules with the clean flag.
---
 .../net/shibboleth/idp/installer/plugin/impl/PluginInstaller.java     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/idp-installer/src/main/java/net/shibboleth/idp/installer/plugin/impl/PluginInstaller.java b/idp-installer/src/main/java/net/shibboleth/idp/installer/plugin/impl/PluginInstaller.java
index 3cfaf1276..da84d7665 100644
--- a/idp-installer/src/main/java/net/shibboleth/idp/installer/plugin/impl/PluginInstaller.java
+++ b/idp-installer/src/main/java/net/shibboleth/idp/installer/plugin/impl/PluginInstaller.java
@@ -292,7 +292,7 @@ public final class PluginInstaller extends AbstractInitializableComponent implem
             try (final RollbackPluginInstall rollback = new RollbackPluginInstall(moduleContext)){
                 for (final IdPModule module: description.getDisableOnRemoval()) {
                     moduleId = module.getId();
-                    module.disable(moduleContext, true);
+                    module.disable(moduleContext, false);
                     rollback.getModulesDisabled().add(module);
                 }
                 rollback.completed();
@@ -469,7 +469,7 @@ public final class PluginInstaller extends AbstractInitializableComponent implem
                 for (final IdPModule module: oldPlugin.getDisableOnRemoval()) {
                     moduleId = module.getId();
                     if (module.isEnabled(moduleContext)) {
-                        module.disable(moduleContext, true);
+                        module.disable(moduleContext, false);
                         rollback.getModulesDisabled().add(module);
                     }
                 }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.