[java-oidc-common] branch main updated: Fix minor syntax and Javadoc issues
Phil Smart
philip.smart at jisc.ac.uk
Mon Feb 1 09:41:18 UTC 2021
This is an automated email from the git hooks/post-receive script.
philsmart pushed a commit to branch main
in repository java-oidc-common.
View the commit online:
http://git.shibboleth.net/view/?p=java-oidc-common.git;a=commit;h=cd77f19ef7fb48e3b224c8198f560b319c5bd847
The following commit(s) were added to refs/heads/main by this push:
new cd77f19 Fix minor syntax and Javadoc issues
cd77f19 is described below
commit cd77f19ef7fb48e3b224c8198f560b319c5bd847
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Mon Feb 1 09:41:14 2021 +0000
Fix minor syntax and Javadoc issues
---
.../jwt/claims/impl/AudienceClaimsValidator.java | 4 +---
.../jwt/claims/impl/ExactMatchClaimsValidator.java | 1 -
.../oidc/security/jwt/claims/impl/IDTokenClaims.java | 2 +-
.../oidc/security/jwt/claims/impl/JWTClaims.java | 2 +-
.../impl/NonceValidationActiviationCondition.java | 5 +++--
.../oidc/security/jwt/claims/impl/package-info.java | 19 -------------------
6 files changed, 6 insertions(+), 27 deletions(-)
diff --git a/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/jwt/claims/impl/AudienceClaimsValidator.java b/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/jwt/claims/impl/AudienceClaimsValidator.java
index e86407a..5ff8f5d 100644
--- a/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/jwt/claims/impl/AudienceClaimsValidator.java
+++ b/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/jwt/claims/impl/AudienceClaimsValidator.java
@@ -1,4 +1,4 @@
-/*
+/*
* Licensed to the University Corporation for Advanced Internet Development,
* Inc. (UCAID) under one or more contributor license agreements. See the
* NOTICE file distributed with this work for additional information regarding
@@ -20,8 +20,6 @@ package net.shibboleth.oidc.security.jwt.claims.impl;
import java.util.List;
import java.util.function.BiFunction;
-import java.util.function.Function;
-
import javax.annotation.Nonnull;
import org.opensaml.profile.context.ProfileRequestContext;
diff --git a/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/jwt/claims/impl/ExactMatchClaimsValidator.java b/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/jwt/claims/impl/ExactMatchClaimsValidator.java
index da11245..d406be8 100644
--- a/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/jwt/claims/impl/ExactMatchClaimsValidator.java
+++ b/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/jwt/claims/impl/ExactMatchClaimsValidator.java
@@ -18,7 +18,6 @@
package net.shibboleth.oidc.security.jwt.claims.impl;
import java.util.function.BiFunction;
-import java.util.function.Function;
import javax.annotation.Nonnull;
diff --git a/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/jwt/claims/impl/IDTokenClaims.java b/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/jwt/claims/impl/IDTokenClaims.java
index 5a85159..ce14bc3 100644
--- a/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/jwt/claims/impl/IDTokenClaims.java
+++ b/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/jwt/claims/impl/IDTokenClaims.java
@@ -51,7 +51,7 @@ public enum IDTokenClaims {
* @param name the registered claim name.
*/
private IDTokenClaims(@Nonnull @NotEmpty final String name) {
- claimName = Constraint.isNotNull(StringSupport.trimOrNull(name), "Claim name can not be null or empt");
+ claimName = Constraint.isNotNull(StringSupport.trimOrNull(name), "Claim name can not be null or empty");
}
/**
diff --git a/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/jwt/claims/impl/JWTClaims.java b/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/jwt/claims/impl/JWTClaims.java
index e82c626..70efb51 100644
--- a/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/jwt/claims/impl/JWTClaims.java
+++ b/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/jwt/claims/impl/JWTClaims.java
@@ -58,7 +58,7 @@ public enum JWTClaims {
* @param name the IANA registered claim name.
*/
private JWTClaims(@Nonnull @NotEmpty final String name) {
- claimName = Constraint.isNotNull(StringSupport.trimOrNull(name), "Claim name can not be null or empt");
+ claimName = Constraint.isNotNull(StringSupport.trimOrNull(name), "Claim name can not be null or empty");
}
/**
diff --git a/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/jwt/claims/impl/NonceValidationActiviationCondition.java b/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/jwt/claims/impl/NonceValidationActiviationCondition.java
index 8cc3e7a..e683956 100644
--- a/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/jwt/claims/impl/NonceValidationActiviationCondition.java
+++ b/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/jwt/claims/impl/NonceValidationActiviationCondition.java
@@ -26,11 +26,12 @@ import org.opensaml.profile.context.ProfileRequestContext;
import com.nimbusds.jwt.JWTClaimsSet;
/**
- * Determines if nonce validation should occur based on if it exists in the JWT claims set. see section 3.1.3.7
- * of the OpenID Connect core 1.0 specification.
+ * Determines if nonce validation should occur. True iff it exists in the JWT claims set, false otherwise.
+ * see section 3.1.3.7 of the OpenID Connect core 1.0 specification.
*/
public class NonceValidationActiviationCondition implements BiPredicate<ProfileRequestContext, JWTClaimsSet>{
+ /** {@inheritdoc}.*/
@Override
public boolean test(@Nonnull final ProfileRequestContext context, @Nonnull final JWTClaimsSet claims) {
diff --git a/oidc-common-crypto-impl/src/test/java/net/shibboleth/oidc/security/jwt/claims/impl/package-info.java b/oidc-common-crypto-impl/src/test/java/net/shibboleth/oidc/security/jwt/claims/impl/package-info.java
deleted file mode 100644
index 0752fb5..0000000
--- a/oidc-common-crypto-impl/src/test/java/net/shibboleth/oidc/security/jwt/claims/impl/package-info.java
+++ /dev/null
@@ -1,19 +0,0 @@
-/*
- * Licensed to the University Corporation for Advanced Internet Development,
- * Inc. (UCAID) under one or more contributor license agreements. See the
- * NOTICE file distributed with this work for additional information regarding
- * copyright ownership. The UCAID licenses this file to You under the Apache
- * License, Version 2.0 (the "License"); you may not use this file except in
- * compliance with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-/** Validation function tests for JWT claims. */
-package net.shibboleth.oidc.security.jwt.claims.impl;
\ No newline at end of file
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the commits
mailing list