[JIRA] (JMVN-14) Real Pom parsing does JIT property replacement

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *created* an issue

Maven Enforcer ( https://shibboleth.atlassian.net/browse/JMVN?atlOrigin=eyJpIjoiZTNiZjM4MDYxZjY0NDJlYzk4MGUwZjc5MTM3NDMxZjciLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/JMVN-14?atlOrigin=eyJpIjoiZTNiZjM4MDYxZjY0NDJlYzk4MGUwZjc5MTM3NDMxZjciLCJwIjoiaiJ9 ) JMVN-14 ( https://shibboleth.atlassian.net/browse/JMVN-14?atlOrigin=eyJpIjoiZTNiZjM4MDYxZjY0NDJlYzk4MGUwZjc5MTM3NDMxZjciLCJwIjoiaiJ9 ) Real Pom parsing does JIT property replacement ( https://shibboleth.atlassian.net/browse/JMVN-14?atlOrigin=eyJpIjoiZTNiZjM4MDYxZjY0NDJlYzk4MGUwZjc5MTM3NDMxZjciLCJwIjoiaiJ9 )

Issue Type: Bug Affects Versions: 3.0 Assignee: Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) Created: 17/Dec/21 6:20 AM Fix Versions: 3,0,1 Priority: Trivial Reporter: Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 )

One of the important (IMO) things about the enforcer's dependency checking is that it parses the poms in an entirely difference (may be more intuitive, maybe not) way from maven.

In testing the V4.1.5-SNAPSHOT with a new logback version we stumbled about such a difference.

The changes to idp-parent pom overrode the logback version property in the idp parent pom but left the parent pom alone. The result of the maven way of parsing was that the property in the idp-parent file was retrospectively applied to the managed dependencies from the shibboleth-parent file when other idp projects were contructed (I think).

The way that the enforcer works (roughly) is that it parses the project parent pom first and then the idp-parent pom (there is some extra juggling involved to do with the oddities of properties).

The "fix" here is to force include the logback depedencies into the idp-parent pom (like we already do for spring, but for the inverse reasons).

One could argue that although the enforcer is throwing up a false positive in this case it is making us think about our pom contents and making it clearer about what we want to ship (the "assumption" that the enforcer is making is not unreasonable). But I could be making the argument because I don't want to have to change the pom parsing at this juncture.

( https://shibboleth.atlassian.net/browse/JMVN-14#add-comment?atlOrigin=eyJpIjoiZTNiZjM4MDYxZjY0NDJlYzk4MGUwZjc5MTM3NDMxZjciLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JMVN-14#add-comment?atlOrigin=eyJpIjoiZTNiZjM4MDYxZjY0NDJlYzk4MGUwZjc5MTM3NDMxZjciLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100187- sha1:fa34960 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20211217/8473d429/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-5b03af1a-6f5e-409f-adcd-eff0942da2a3
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211217/8473d429/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-835040e6-e472-4e2f-ade5-6b77afc16ffe
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211217/8473d429/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-3f5483af-b11e-423d-b4c9-d34fa74e624e
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211217/8473d429/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-a6196570-f666-40c4-a82b-80b22c596083
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211217/8473d429/attachment-0007.png>