[JIRA] (JCOMOIDC-21) Move net.shibboleth.idp.plugin.oidc.op.config from oidc-op-impl into commons

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on JCOMOIDC-21 ( https://shibboleth.atlassian.net/browse/JCOMOIDC-21?atlOrigin=eyJpIjoiZTM3ZDJiZmI3OTNiNGIxNjlhNDI4OWQ5MTFiODllMDAiLCJwIjoiaiJ9 )

Re: Move net.shibboleth.idp.plugin.oidc.op.config from oidc-op-impl into commons ( https://shibboleth.atlassian.net/browse/JCOMOIDC-21?atlOrigin=eyJpIjoiZTM3ZDJiZmI3OTNiNGIxNjlhNDI4OWQ5MTFiODllMDAiLCJwIjoiaiJ9 )

I moved some missing adjacent material, including all the strategy functions and predicates used to access the classes, which will be needed as well. These are in many cases in the saml-api modules for comparison.

The old classes are removed and I’ve refactored the OP code as well as added some missing strategy code to remove most all of the direct config class dependencies from the profile actions.

The OP tests pass for me locally, probably will hit a glitch or two.

I expect we will need to move more code out of the OP packages over time.

One major issue: a couple of the old interfaces were in the OP’s API module such as OIDCProfileConfiguration. There’s really no help for it but to make a policy exception here and remove the old APIs and just make a note of it. I don’t expect that to be a big deal.

Oddly the old AuthenticationContextClassRefPrincipal class was not API, but I wouldn’t be shocked if somebody had a reference to that in a script somewhere, so should also be noted as a change.

I will open a separate ticket for possible renaming or refactoring of the profile classes. Nobody loves the way it’s laid out now but it may be disruptive to change, TBD.

( https://shibboleth.atlassian.net/browse/JCOMOIDC-21#add-comment?atlOrigin=eyJpIjoiZTM3ZDJiZmI3OTNiNGIxNjlhNDI4OWQ5MTFiODllMDAiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JCOMOIDC-21#add-comment?atlOrigin=eyJpIjoiZTM3ZDJiZmI3OTNiNGIxNjlhNDI4OWQ5MTFiODllMDAiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100183- sha1:f6eba4b )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20211207/acde86ec/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-2d81a62a-58e0-4d7f-a487-81c50a8abaa7
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211207/acde86ec/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-77a3782d-f804-4ad5-a9f5-c5356427c189
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211207/acde86ec/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-aef4a398-6767-4043-946e-1e1efbfec8d4
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211207/acde86ec/attachment-0005.png>