[JIRA] (JPAR-185) Site builds are not compatible with Maven 3.8.2

Wed Aug 25 08:51:48 UTC 2021

Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *created* an issue

Java Parent Project ( https://shibboleth.atlassian.net/browse/JPAR?atlOrigin=eyJpIjoiZmI0ODAyNTUzOGU2NGY1OWI1YWM0NGRiMDc3ZDA4NGEiLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/JPAR-185?atlOrigin=eyJpIjoiZmI0ODAyNTUzOGU2NGY1OWI1YWM0NGRiMDc3ZDA4NGEiLCJwIjoiaiJ9 ) JPAR-185 ( https://shibboleth.atlassian.net/browse/JPAR-185?atlOrigin=eyJpIjoiZmI0ODAyNTUzOGU2NGY1OWI1YWM0NGRiMDc3ZDA4NGEiLCJwIjoiaiJ9 ) Site builds are not compatible with Maven 3.8.2 ( https://shibboleth.atlassian.net/browse/JPAR-185?atlOrigin=eyJpIjoiZmI0ODAyNTUzOGU2NGY1OWI1YWM0NGRiMDc3ZDA4NGEiLCJwIjoiaiJ9 )

Issue Type: Bug Affects Versions: 11.2.1 Assignee: Unassigned Created: 25/Aug/21 4:51 AM Priority: Trivial Reporter: Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 )

I've marked this as a bug, although it's not clear that it's our bug or even that it's fixable.

I have been using MacPorts' installation of `maven3` for a while with good success; that's been Maven 3.6.3 for quite some time (December 2019), and everything seems to work with that version.

MacPorts updated to Maven 3.8.1 in April 2021; this version addressed a couple of CVEs and also seems to have been largely fine.

A week or so ago, Macports updated to Maven 3.8.2, a release which is described in its release notes as having some "Known Issues": https://maven.apache.org/docs/3.8.2/release-notes.html#known-issues

3.8.2 appears to break site builds, with results like this:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.9.1:site ( default -site) on project aggregator-pipeline: Error generating maven-javadoc-plugin:3.3.0:test-aggregate report: 
[ERROR] Exit code: 1 - /Volumes/Cased/git/shib/java-metadata-aggregator/aggregator-pipeline/src/test/java/net/shibboleth/metadata/AssertSupport.java:26: error: package org.testng does not exist
[ERROR] import org.testng.Assert;
[ERROR]                  ^

Our current parent POM enforces a minimum of Maven 3.5.3, for what it's worth. It would be possible in principle to use the range syntax in the enforcer plugin to enforce a maximum of Maven 3.8.1, although I'm not sure how valuable that really is.

For now, though, at least if you want to do "site" builds, you need to get your copy of Maven from somewhere other than MacPorts, as they don't support version pinning or installation of old versions (unless you make your own ports repository).

If setting up a new machine, you also need to avoid just picking the latest version of Maven.

( https://shibboleth.atlassian.net/browse/JPAR-185#add-comment?atlOrigin=eyJpIjoiZmI0ODAyNTUzOGU2NGY1OWI1YWM0NGRiMDc3ZDA4NGEiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JPAR-185#add-comment?atlOrigin=eyJpIjoiZmI0ODAyNTUzOGU2NGY1OWI1YWM0NGRiMDc3ZDA4NGEiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100174- sha1:b411b23 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20210825/77126a83/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-5d6105bc-96cf-4c3d-80d1-9ea96879570e
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20210825/77126a83/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-551f10d1-effb-4524-a626-e23a7abde48a
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20210825/77126a83/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-2b98d7e9-078b-45a7-a4a8-30ce4039a124
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20210825/77126a83/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-3e826b4a-c8c9-4d24-9e38-d4c8e6f3977b
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20210825/77126a83/attachment-0007.png>