[JIRA] (OSJ-340) Logger instances improvement

Serc Gil Salor (Jira) jira at shibboleth.atlassian.net
Tue Aug 17 09:22:23 UTC 2021


Serc Gil Salor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Aa1e3c2c0-95f1-4ca3-aaa1-309ac5d6e7ee ) *created* an issue

OpenSAML - Java ( https://shibboleth.atlassian.net/browse/OSJ?atlOrigin=eyJpIjoiM2QxZjQwMTdiM2E1NDA2ODg4ZGU2YTIwMGFjNGQxZjYiLCJwIjoiaiJ9 ) / Improvement ( https://shibboleth.atlassian.net/browse/OSJ-340?atlOrigin=eyJpIjoiM2QxZjQwMTdiM2E1NDA2ODg4ZGU2YTIwMGFjNGQxZjYiLCJwIjoiaiJ9 ) OSJ-340 ( https://shibboleth.atlassian.net/browse/OSJ-340?atlOrigin=eyJpIjoiM2QxZjQwMTdiM2E1NDA2ODg4ZGU2YTIwMGFjNGQxZjYiLCJwIjoiaiJ9 ) Logger instances improvement ( https://shibboleth.atlassian.net/browse/OSJ-340?atlOrigin=eyJpIjoiM2QxZjQwMTdiM2E1NDA2ODg4ZGU2YTIwMGFjNGQxZjYiLCJwIjoiaiJ9 )

Issue Type: Improvement Affects Versions: 3.3.0 Assignee: Brent Putman ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A97de0981-adc3-4044-95ed-131622fad81e ) Components: Core Classes Created: 17/Aug/21 5:22 AM Priority: Trivial Reporter: Serc Gil Salor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Aa1e3c2c0-95f1-4ca3-aaa1-309ac5d6e7ee )

Hello,

Recently we have encountered an issue where there is a high CPU usage in our system and it is pointing to our code using AbstractXMLObjectUnmarshaller. Upon further investigation, this has been caused by an existing bug in JDK 11 where the current workaround is to just set the Logger instances to static.

I have checked that there is already an open issue ( https://shibboleth.atlassian.net/browse/OSJ-334 ) related to this , and based on the comment the fix would be to change the Logger instances to static. I'm not sure what is the scope of this change, so i would just like to propose that it covers all the `Logger` instances in the codebase.

Thank you

( https://shibboleth.atlassian.net/browse/OSJ-340#add-comment?atlOrigin=eyJpIjoiM2QxZjQwMTdiM2E1NDA2ODg4ZGU2YTIwMGFjNGQxZjYiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/OSJ-340#add-comment?atlOrigin=eyJpIjoiM2QxZjQwMTdiM2E1NDA2ODg4ZGU2YTIwMGFjNGQxZjYiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100172- sha1:02b07ac )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20210817/261d9f0d/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-9a0952e8-b13a-453e-b406-7c5ace642f5b
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20210817/261d9f0d/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-e84655dc-89ca-4e34-9300-84c642cbf836
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20210817/261d9f0d/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-29428f58-77b9-47d2-a028-6154e8954359
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20210817/261d9f0d/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-5abfe09b-1884-484f-b3ee-090bc7e5217e
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20210817/261d9f0d/attachment-0007.png>


More information about the commits mailing list