[java-idp-plugin-duo] branch main updated: GEN-266 - Seal as many jars as practical via Maven manifest customization

Phil Smart philip.smart at jisc.ac.uk
Tue Apr 27 10:45:18 UTC 2021


This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-duo.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-duo.git;a=commit;h=66b4d80f887ac4aef5f514f161b403da2a22875f

The following commit(s) were added to refs/heads/main by this push:
       new  66b4d80   GEN-266 - Seal as many jars as practical via Maven manifest customization
66b4d80 is described below

commit 66b4d80f887ac4aef5f514f161b403da2a22875f
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Tue Apr 27 11:45:15 2021 +0100

    GEN-266 - Seal as many jars as practical via Maven manifest
    customization
    
    - Seal all jars
    - Cleanup maven-jar-plugin config e.g. move some common settings to the
    new parent config.
    
    https://issues.shibboleth.net/jira/browse/GEN-266
---
 idp-duo-api/pom.xml                |  1 -
 idp-duo-impl/pom.xml               | 12 ++++++++++++
 idp-duo-nimbus-client-impl/pom.xml |  6 +-----
 idp-duo-sdk-client-impl/pom.xml    |  6 +-----
 pom.xml                            | 18 ++++++++++++++++++
 5 files changed, 32 insertions(+), 11 deletions(-)

diff --git a/idp-duo-api/pom.xml b/idp-duo-api/pom.xml
index dd0789b..3353867 100644
--- a/idp-duo-api/pom.xml
+++ b/idp-duo-api/pom.xml
@@ -66,7 +66,6 @@
                 <artifactId>maven-jar-plugin</artifactId>
                 <configuration>
                     <archive>
-                        <index>true</index>
                         <manifestEntries>
                             <Main-Class>net.shibboleth.idp.plugin.authn.duo.Version</Main-Class>
                         </manifestEntries>
diff --git a/idp-duo-impl/pom.xml b/idp-duo-impl/pom.xml
index 7b675b5..4c28ecf 100644
--- a/idp-duo-impl/pom.xml
+++ b/idp-duo-impl/pom.xml
@@ -172,6 +172,18 @@
 				<groupId>org.apache.maven.plugins</groupId>
 				<artifactId>maven-jar-plugin</artifactId>
 				<configuration>
+				    <archive>                      
+                        <manifestSections>
+                            <manifestSection>
+                                <name>net/shibboleth/idp/plugin/authn/duo/impl/</name>
+                                <manifestEntries>
+                                    <Implementation-Title>${project.artifactId}</Implementation-Title>
+                                    <Implementation-Version>${project.version}</Implementation-Version>
+                                    <Implementation-Vendor>shibboleth.net</Implementation-Vendor>
+                                </manifestEntries>
+                            </manifestSection>
+                        </manifestSections>
+                    </archive>
 					<excludes>
 						<exclude>system/**</exclude>
 						<exclude>conf/**</exclude>
diff --git a/idp-duo-nimbus-client-impl/pom.xml b/idp-duo-nimbus-client-impl/pom.xml
index 6e1fe59..5fe09de 100644
--- a/idp-duo-nimbus-client-impl/pom.xml
+++ b/idp-duo-nimbus-client-impl/pom.xml
@@ -101,11 +101,7 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-jar-plugin</artifactId>
                 <configuration>
-                    <archive>
-                        <index>true</index>
-                        <manifestEntries>
-                            <Automatic-Module-Name>${automatic.module.name}</Automatic-Module-Name>
-                        </manifestEntries>
+                    <archive>                      
                         <manifestSections>
                             <manifestSection>
                                 <name>net/shibboleth/idp/plugin/authn/duo/nimbus/</name>
diff --git a/idp-duo-sdk-client-impl/pom.xml b/idp-duo-sdk-client-impl/pom.xml
index 7a82123..3ae1ccc 100644
--- a/idp-duo-sdk-client-impl/pom.xml
+++ b/idp-duo-sdk-client-impl/pom.xml
@@ -153,11 +153,7 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-jar-plugin</artifactId>
                 <configuration>
-                    <archive>
-                        <index>true</index>
-                        <manifestEntries>
-                            <Automatic-Module-Name>${automatic.module.name}</Automatic-Module-Name>
-                        </manifestEntries>
+                    <archive>                       
                         <manifestSections>
                             <manifestSection>
                                 <name>net/shibboleth/idp/plugin/authn/duo/sdk/</name>
diff --git a/pom.xml b/pom.xml
index 6f0ef77..ebd1fff 100644
--- a/pom.xml
+++ b/pom.xml
@@ -141,4 +141,22 @@
         </dependencies>
     </dependencyManagement>
 
+	<build>
+		<plugins>
+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-jar-plugin</artifactId>
+				<configuration>
+					<archive>
+					    <index>true</index>
+						<manifestEntries>
+							<Automatic-Module-Name>${automatic.module.name}</Automatic-Module-Name>
+							<Sealed>true</Sealed>
+						</manifestEntries>
+					</archive>
+				</configuration>
+			</plugin>
+		</plugins>
+	</build>
+
 </project>

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list