[java-identity-provider] branch main updated: Improve logging on loop detection.

Scott Cantor cantor.2 at osu.edu
Mon Apr 19 13:46:36 UTC 2021


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=ca14ef1787fbf0449ac4dd1ee1f409ef5dac2e27

The following commit(s) were added to refs/heads/main by this push:
       new  ca14ef178 Improve logging on loop detection.
ca14ef178 is described below

commit ca14ef1787fbf0449ac4dd1ee1f409ef5dac2e27
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Mon Apr 19 09:46:34 2021 -0400

    Improve logging on loop detection.
---
 .../net/shibboleth/idp/profile/logic/LoopDetectionPredicate.java   | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/idp-profile-api/src/main/java/net/shibboleth/idp/profile/logic/LoopDetectionPredicate.java b/idp-profile-api/src/main/java/net/shibboleth/idp/profile/logic/LoopDetectionPredicate.java
index 0eda3c4bb..eeb867b7c 100644
--- a/idp-profile-api/src/main/java/net/shibboleth/idp/profile/logic/LoopDetectionPredicate.java
+++ b/idp-profile-api/src/main/java/net/shibboleth/idp/profile/logic/LoopDetectionPredicate.java
@@ -106,10 +106,11 @@ public class LoopDetectionPredicate extends AbstractRelyingPartyPredicate {
         final RelyingPartyContext rpCtx = getRelyingPartyContextLookupStrategy().apply(input);
         
         if (username != null && rpCtx != null && rpCtx.getRelyingPartyId() != null) {
-            final String meterName = relyingPartyMap.get(rpCtx.getRelyingPartyId());
+            String meterName = relyingPartyMap.get(rpCtx.getRelyingPartyId());
             if (meterName != null) {
-                final Meter meter = MetricsSupport.getMetricRegistry().meter(
-                        MetricRegistry.name("net.shibboleth.idp.loopDetection", meterName, username.replace(".","")),
+                meterName = MetricRegistry.name("net.shibboleth.idp.loopDetection", meterName,
+                        username.replace(".",""));
+                final Meter meter = MetricsSupport.getMetricRegistry().meter(meterName,
                         new MetricSupplier<Meter>() {
                             public Meter newMetric() {
                                 return new Meter(new SlidingTimeWindowMovingAverages());

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list