[java-support] branch main updated: JSPT-105 Catch exceptions thrown by LanguageRange#Parse(Sting)

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-support.

View the commit online:
http://git.shibboleth.net/view/?p=java-support.git;a=commit;h=6891b952ae0cb48f80240b3fa0ecd456fa263521

The following commit(s) were added to refs/heads/main by this push:
       new  6891b95   JSPT-105 Catch exceptions thrown by LanguageRange#Parse(Sting)
6891b95 is described below

commit 6891b952ae0cb48f80240b3fa0ecd456fa263521
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Tue Apr 13 15:46:05 2021 +0100

    JSPT-105 Catch exceptions thrown by LanguageRange#Parse(Sting)
    
    https://issues.shibboleth.net/jira/browse/JSPT-105
    
    Change test to reflect real life customer issues
---
 .../utilities/java/support/net/HttpServletSupportTest.java   | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/test/java/net/shibboleth/utilities/java/support/net/HttpServletSupportTest.java b/src/test/java/net/shibboleth/utilities/java/support/net/HttpServletSupportTest.java
index 5ac8faa..e801063 100644
--- a/src/test/java/net/shibboleth/utilities/java/support/net/HttpServletSupportTest.java
+++ b/src/test/java/net/shibboleth/utilities/java/support/net/HttpServletSupportTest.java
@@ -18,6 +18,8 @@
 package net.shibboleth.utilities.java.support.net;
 
 import java.util.Collections;
+import java.util.List;
+import java.util.Locale.LanguageRange;
 import java.util.Set;
 
 import org.springframework.mock.web.MockHttpServletRequest;
@@ -157,10 +159,12 @@ public class HttpServletSupportTest {
         MockHttpServletRequest request =  new MockHttpServletRequest();
 
         Assert.assertTrue(HttpServletSupport.getLanguageRange(request).isEmpty());
-        request.addHeader("Accept-Language", "en-us");
-        Assert.assertEquals(HttpServletSupport.getLanguageRange(request).size(), 1);
+        request.addHeader("Accept-Language", "en-GB,fr-FR;q=0.7,en;q=0.3");
+        List<LanguageRange> ranges = HttpServletSupport.getLanguageRange(request);
+        Assert.assertEquals(ranges.size(), 4);
         request =  new MockHttpServletRequest();
-        request.addHeader("Accept-Language", "A Random Pile Of Garbage");
-        Assert.assertTrue(HttpServletSupport.getLanguageRange(request).isEmpty());
+        request.addHeader("Accept-Language", "en-ca;en-us");
+        ranges = HttpServletSupport.getLanguageRange(request);
+        Assert.assertTrue(ranges.isEmpty());
     }
 }
\ No newline at end of file

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.