[java-idp-plugin-totp] branch main updated: IDP-1679 Remove spurious plugin test

Rod Widdowson rdw at steadingsoftware.com
Sun Sep 20 14:45:14 UTC 2020


This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-idp-plugin-totp.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-totp.git;a=commit;h=d70c0409d736e6ac03bb646e65618003c8f9bd11

The following commit(s) were added to refs/heads/main by this push:
       new  d70c040   IDP-1679 Remove spurious plugin test
d70c040 is described below

commit d70c0409d736e6ac03bb646e65618003c8f9bd11
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Sun Sep 20 15:43:12 2020 +0100

    IDP-1679 Remove spurious plugin test
    
    https://issues.shibboleth.net/jira/browse/IDP-1679
---
 totp-impl/pom.xml                                  |  5 --
 .../net/shibboleth/idp/plugin/totp/PluginTest.java | 65 ----------------------
 2 files changed, 70 deletions(-)

diff --git a/totp-impl/pom.xml b/totp-impl/pom.xml
index 3e4d338..8726d04 100644
--- a/totp-impl/pom.xml
+++ b/totp-impl/pom.xml
@@ -132,11 +132,6 @@
             <scope>test</scope>
             <type>test-jar</type>
         </dependency>
-        <dependency>
-            <groupId>${idp.groupId}</groupId>
-            <artifactId>idp-admin-impl</artifactId>
-            <scope>test</scope>
-        </dependency>
         <dependency>
             <groupId>${opensaml.groupId}</groupId>
             <artifactId>opensaml-core</artifactId>
diff --git a/totp-impl/src/test/java/net/shibboleth/idp/plugin/totp/PluginTest.java b/totp-impl/src/test/java/net/shibboleth/idp/plugin/totp/PluginTest.java
deleted file mode 100644
index 5331a4e..0000000
--- a/totp-impl/src/test/java/net/shibboleth/idp/plugin/totp/PluginTest.java
+++ /dev/null
@@ -1,65 +0,0 @@
-/*
- * Licensed to the University Corporation for Advanced Internet Development,
- * Inc. (UCAID) under one or more contributor license agreements.  See the
- * NOTICE file distributed with this work for additional information regarding
- * copyright ownership. The UCAID licenses this file to You under the Apache
- * License, Version 2.0 (the "License"); you may not use this file except in
- * compliance with the License.  You may obtain a copy of the License at
- *
- *    http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package net.shibboleth.idp.plugin.totp;
-
-import static org.testng.Assert.assertEquals;
-import static org.testng.Assert.assertFalse;
-import static org.testng.Assert.assertNotNull;
-import static org.testng.Assert.assertTrue;
-
-import java.util.ServiceLoader;
-
-import org.testng.annotations.BeforeClass;
-import org.testng.annotations.Test;
-
-import net.shibboleth.idp.plugin.PluginDescription;
-import net.shibboleth.idp.plugin.PluginVersion;
-import net.shibboleth.idp.plugin.PluginSupport.SupportLevel;
-import net.shibboleth.idp.plugin.impl.PluginState;
-import net.shibboleth.utilities.java.support.component.ComponentInitializationException;
-
-/**  basic sanity tests */
- at SuppressWarnings("javadoc")
-public class PluginTest {
-
-	private PluginDescription totp;
-
-	@BeforeClass
-	public void SetupPlugin() {
-		final ServiceLoader<PluginDescription> loader = ServiceLoader.load(PluginDescription.class);
-		for (final PluginDescription service:loader) {
-			if (getClass().getPackageName().contentEquals(service.getPluginId())) {
-				totp = service;
-				break;
-			}
-		}
-		assertNotNull(totp);
-	}
-
-	@Test
-	public void testState() throws ComponentInitializationException {
-		
-		final PluginState state = new PluginState(totp); 
-		state.initialize();
-        final PluginVersion version = new PluginVersion(totp.getMajorVersion(),totp.getMinorVersion(), totp.getPatchVersion()); 
-        assertTrue(state.getAvailableVersions().containsKey(version));
-        assertEquals(state.getCurrentInfo().getSupportLevel(), SupportLevel.Current);
-        assertTrue(state.isSupportedWithIdPVersion(version, new PluginVersion("4.1.0")));
-        assertFalse(state.isSupportedWithIdPVersion(version, new PluginVersion("5.0.0")));
-	}
-}

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list