[java-idp-oidc] 32/44: JOIDC-5 Changed the ACS binding matching the redirect_uri.

[Henri Mikkonen]

This is an automated email from the git hooks/post-receive script.

hjmikkon pushed a commit to branch main
in repository java-idp-oidc.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-oidc.git;a=commit;h=92b7a627a8fd99fab8566c695ae9a6e55e508c9f

commit 92b7a627a8fd99fab8566c695ae9a6e55e508c9f
Author: Henri Mikkonen <henri.mikkonen at iki.fi>
AuthorDate: Fri Jul 3 14:57:23 2020 +0300

    JOIDC-5 Changed the ACS binding matching the redirect_uri.
    
    https://issues.shibboleth.net/jira/browse/JOIDC-5
    
    The new value (https://tools.ietf.org/html/rfc6749#section-3.1.2)
    seems to be the best candidate for a link directing to the definition
    of a redirect_uri.
---
 .../oidc/metadata/impl/ClientInformationNodeProcessor.java         | 7 +++++--
 .../oidc/metadata/impl/EntitiesDescriptor-with-oidcmd.xml          | 4 ++--
 .../metadata/impl/EntityDescriptor-with-oidcmd-clientsecret.xml    | 2 +-
 3 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/metadata/impl/ClientInformationNodeProcessor.java b/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/metadata/impl/ClientInformationNodeProcessor.java
index 7058db8b..031e969d 100644
--- a/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/metadata/impl/ClientInformationNodeProcessor.java
+++ b/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/metadata/impl/ClientInformationNodeProcessor.java
@@ -83,6 +83,9 @@ import net.shibboleth.utilities.java.support.resolver.ResolverException;
  * is fetched mainly via {@link OAuthRPExtensions}.
  */
 public class ClientInformationNodeProcessor implements MetadataNodeProcessor {
+
+    /** The ACS binding identifier matching to the redirect_uri. */
+    public static final String BINDING_ID_REDIRECT_URI = "https://tools.ietf.org/html/rfc6749#section-3.1.2";
     
     /** Class logger. */
     private final Logger log = LoggerFactory.getLogger(ClientInformationNodeProcessor.class);
@@ -507,7 +510,7 @@ public class ClientInformationNodeProcessor implements MetadataNodeProcessor {
     
     /**
      * Parse the redirection URIs from the given role descriptor. Only the assertion consumer service URLs whose
-     * binding matches to {@link OIDCCoreProtocolConfiguration#PROFILE_ID} are taken into consideration.
+     * binding matches to {@link #BINDING_ID_REDIRECT_URI} are taken into consideration.
      * 
      * @param roleDescriptor The role descriptor to parse from.
      * @return The set of redirection URIs that were successfully parsed.
@@ -515,7 +518,7 @@ public class ClientInformationNodeProcessor implements MetadataNodeProcessor {
     protected @Nonnull Set<URI> parseRedirectUris(final @Nonnull SPSSODescriptor roleDescriptor) {
         final Set<URI> uris = new HashSet<>();
         for (final AssertionConsumerService acs : roleDescriptor.getAssertionConsumerServices()) {
-            if (OIDCCoreProtocolConfiguration.PROFILE_ID.equals(acs.getBinding())) {
+            if (BINDING_ID_REDIRECT_URI.equals(acs.getBinding())) {
                 final URI uri = getSingleURIValue(acs.getLocation());
                 if (uri != null) {
                     uris.add(uri);
diff --git a/idp-oidc-extension-impl/src/test/resources/org/geant/idpextension/oidc/metadata/impl/EntitiesDescriptor-with-oidcmd.xml b/idp-oidc-extension-impl/src/test/resources/org/geant/idpextension/oidc/metadata/impl/EntitiesDescriptor-with-oidcmd.xml
index d813391a..4c440fbd 100644
--- a/idp-oidc-extension-impl/src/test/resources/org/geant/idpextension/oidc/metadata/impl/EntitiesDescriptor-with-oidcmd.xml
+++ b/idp-oidc-extension-impl/src/test/resources/org/geant/idpextension/oidc/metadata/impl/EntitiesDescriptor-with-oidcmd.xml
@@ -123,11 +123,11 @@
                 </oidcmd:OAuthRPExtensions>
             </md:Extensions>
             <md:AssertionConsumerService
-                    Binding="http://csc.fi/ns/profiles/oidc/sso/browser"
+                    Binding="https://tools.ietf.org/html/rfc6749#section-3.1.2"
                     Location="https://example.org/cb"
                     index="1"/>
             <md:AssertionConsumerService
-                    Binding="http://csc.fi/ns/profiles/oidc/sso/browser"
+                    Binding="https://tools.ietf.org/html/rfc6749#section-3.1.2"
                     Location="https://example.org/cb2"
                     index="2"/>
             <md:AssertionConsumerService
diff --git a/idp-oidc-extension-impl/src/test/resources/org/geant/idpextension/oidc/metadata/impl/EntityDescriptor-with-oidcmd-clientsecret.xml b/idp-oidc-extension-impl/src/test/resources/org/geant/idpextension/oidc/metadata/impl/EntityDescriptor-with-oidcmd-clientsecret.xml
index 451e67dd..736230a6 100644
--- a/idp-oidc-extension-impl/src/test/resources/org/geant/idpextension/oidc/metadata/impl/EntityDescriptor-with-oidcmd-clientsecret.xml
+++ b/idp-oidc-extension-impl/src/test/resources/org/geant/idpextension/oidc/metadata/impl/EntityDescriptor-with-oidcmd-clientsecret.xml
@@ -18,7 +18,7 @@
             </oidcmd:OAuthRPExtensions>
         </md:Extensions>
         <md:AssertionConsumerService
-                Binding="http://csc.fi/ns/profiles/oidc/sso/browser"
+                Binding="https://tools.ietf.org/html/rfc6749#section-3.1.2"
                 Location="https://example.org/cb"
                 index="1"/>
          <md:NameIDFormat>public</md:NameIDFormat>

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.