[java-idp-plugin-duo] 04/16: Return after failure

[Phil Smart]

This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-duo.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-duo.git;a=commit;h=359837189819d0805af8c8a47091590988b4b41f

commit 359837189819d0805af8c8a47091590988b4b41f
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Fri Sep 18 17:42:56 2020 +0100

    Return after failure
---
 .../plugin/authn/duo/impl/ValidateDuoTokenAuthenticationResult.java   | 1 +
 .../shibboleth/idp/plugin/authn/duo/impl/ValidateTokenSignature.java  | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/ValidateDuoTokenAuthenticationResult.java b/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/ValidateDuoTokenAuthenticationResult.java
index ec1cba4..8868596 100644
--- a/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/ValidateDuoTokenAuthenticationResult.java
+++ b/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/ValidateDuoTokenAuthenticationResult.java
@@ -167,6 +167,7 @@ public class ValidateDuoTokenAuthenticationResult extends AbstractValidationActi
             handleError(profileRequestContext, authenticationContext,"Unexepected Authentication Response", 
                     AuthnEventIds.AUTHN_EXCEPTION);
             recordFailure(profileRequestContext);
+            return;
         }
         
         final Object statusObj = authStatusObject.get(DuoOIDCAuthAPI.DUO_AUTH_RESULT_STATUS_JSON_OBJECT);
diff --git a/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/ValidateTokenSignature.java b/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/ValidateTokenSignature.java
index c696325..685b605 100644
--- a/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/ValidateTokenSignature.java
+++ b/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/ValidateTokenSignature.java
@@ -44,8 +44,8 @@ import net.shibboleth.idp.plugin.authn.duo.context.DuoOIDCAuthenticationContext;
 
 
 /**
- * Action to validate the JWT signature. The JWT **must** be signed using the HMAC_SHA family.
- * Any other type, or 'none', emits and error back to the flow.
+ * Action to validate the JWT signature. The JWT **must** be signed using the HMAC_SHA family,
+ * any other type including 'none', emits an error back to the flow.
  */
 public class ValidateTokenSignature extends AbstractDuoAuthenticationAction {
     

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.