[java-idp-plugin-duo] branch main updated: Fix test JavaDoc
Phil Smart
philip.smart at jisc.ac.uk
Tue Nov 24 17:06:08 UTC 2020
This is an automated email from the git hooks/post-receive script.
philsmart pushed a commit to branch main
in repository java-idp-plugin-duo.
View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-duo.git;a=commit;h=0922ab9499e2c3b58a1cb403a8ca160429aaff48
The following commit(s) were added to refs/heads/main by this push:
new 0922ab9 Fix test JavaDoc
0922ab9 is described below
commit 0922ab9499e2c3b58a1cb403a8ca160429aaff48
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Tue Nov 24 17:06:03 2020 +0000
Fix test JavaDoc
---
.../idp/plugin/authn/duo/impl/ValidateTokenClaimsTest.java | 2 +-
.../idp/plugin/authn/duo/impl/ValidateTokenSignatureTest.java | 6 +++++-
.../net/shibboleth/idp/plugin/authn/mock/MockFlowBuilder.java | 4 ++++
.../idp/plugin/authn/duo/sdk/impl/DuoSDKClientFactoryTest.java | 10 +++++++---
4 files changed, 17 insertions(+), 5 deletions(-)
diff --git a/idp-duo-impl/src/test/java/net/shibboleth/idp/plugin/authn/duo/impl/ValidateTokenClaimsTest.java b/idp-duo-impl/src/test/java/net/shibboleth/idp/plugin/authn/duo/impl/ValidateTokenClaimsTest.java
index 529f12f..bdd45cf 100644
--- a/idp-duo-impl/src/test/java/net/shibboleth/idp/plugin/authn/duo/impl/ValidateTokenClaimsTest.java
+++ b/idp-duo-impl/src/test/java/net/shibboleth/idp/plugin/authn/duo/impl/ValidateTokenClaimsTest.java
@@ -51,7 +51,7 @@ import net.shibboleth.utilities.java.support.component.ComponentInitializationEx
import net.shibboleth.utilities.java.support.logic.ConstraintViolationException;
/**
- * Tests for the {@link ValidateDuoTokenAudience} class.
+ * Tests for the {@link ValidateTokenClaims} class.
*/
public class ValidateTokenClaimsTest extends AbstractDuoActionTest {
diff --git a/idp-duo-impl/src/test/java/net/shibboleth/idp/plugin/authn/duo/impl/ValidateTokenSignatureTest.java b/idp-duo-impl/src/test/java/net/shibboleth/idp/plugin/authn/duo/impl/ValidateTokenSignatureTest.java
index 4ced4c7..5eb6ca5 100644
--- a/idp-duo-impl/src/test/java/net/shibboleth/idp/plugin/authn/duo/impl/ValidateTokenSignatureTest.java
+++ b/idp-duo-impl/src/test/java/net/shibboleth/idp/plugin/authn/duo/impl/ValidateTokenSignatureTest.java
@@ -49,7 +49,7 @@ import net.shibboleth.utilities.java.support.codec.EncodingException;
import net.shibboleth.utilities.java.support.component.ComponentInitializationException;
/**
- * Tests for the {@link ValidateDuoTokenAudience} class.
+ * Tests for the {@link ValidateTokenSignature} class.
*/
public class ValidateTokenSignatureTest extends AbstractDuoActionTest {
@@ -86,6 +86,7 @@ public class ValidateTokenSignatureTest extends AbstractDuoActionTest {
* Test Duo 2FA token signature validation with an unsupported signature, should fail.
*
* @throws ComponentInitializationException on error.
+ * @throws EncodingException on error.
*/
@Test
public final void testUnsuportedSignature() throws ComponentInitializationException, EncodingException {
@@ -109,6 +110,7 @@ public class ValidateTokenSignatureTest extends AbstractDuoActionTest {
* Test Duo 2FA token signature validation with a valid signature, should succeed.
*
* @throws ComponentInitializationException on error.
+ * @throws EncodingException on error.
*/
@Test
public final void testValidSignature() throws ComponentInitializationException, EncodingException {
@@ -132,6 +134,7 @@ public class ValidateTokenSignatureTest extends AbstractDuoActionTest {
* Test Duo 2FA token signature validation with an invalid signature, should fail.
*
* @throws ComponentInitializationException on error.
+ * @throws EncodingException on error.
*/
@Test
public final void testInvalidSignature() throws ComponentInitializationException, EncodingException {
@@ -157,6 +160,7 @@ public class ValidateTokenSignatureTest extends AbstractDuoActionTest {
* The JWT header is present with a signature algorithm other than none, but the token has not been signed.
*
* @throws ComponentInitializationException on error.
+ * @throws EncodingException on error.
*/
@Test
public final void testSignatureNotPresent() throws ComponentInitializationException, EncodingException {
diff --git a/idp-duo-impl/src/test/java/net/shibboleth/idp/plugin/authn/mock/MockFlowBuilder.java b/idp-duo-impl/src/test/java/net/shibboleth/idp/plugin/authn/mock/MockFlowBuilder.java
index d1c1aa4..f5d4b1e 100644
--- a/idp-duo-impl/src/test/java/net/shibboleth/idp/plugin/authn/mock/MockFlowBuilder.java
+++ b/idp-duo-impl/src/test/java/net/shibboleth/idp/plugin/authn/mock/MockFlowBuilder.java
@@ -45,6 +45,10 @@ public final class MockFlowBuilder {
/**
* Create a simple flow with one start-state which transitions to an
* end-state that ends the flow. The flow does nothing.
+ *
+ * @param flowId the flow identifier.
+ *
+ * @return the constructed mock flow.
*/
public static Flow MockNoOpFlow(@Nonnull @NotEmpty final String flowId) {
Assert.notNull(flowId, "Flow to mock must have an ID");
diff --git a/idp-duo-native-client-impl/src/test/java/net/shibboleth/idp/plugin/authn/duo/sdk/impl/DuoSDKClientFactoryTest.java b/idp-duo-native-client-impl/src/test/java/net/shibboleth/idp/plugin/authn/duo/sdk/impl/DuoSDKClientFactoryTest.java
index 7e0f167..4aa34f4 100644
--- a/idp-duo-native-client-impl/src/test/java/net/shibboleth/idp/plugin/authn/duo/sdk/impl/DuoSDKClientFactoryTest.java
+++ b/idp-duo-native-client-impl/src/test/java/net/shibboleth/idp/plugin/authn/duo/sdk/impl/DuoSDKClientFactoryTest.java
@@ -52,7 +52,11 @@ public class DuoSDKClientFactoryTest {
/** The factory to test.*/
private DuoSDKClientFactory factory;
- /** Setup.*/
+ /**
+ * Setup.
+ *
+ * @throws Exception on error.
+ */
@BeforeMethod
public void setUp() throws Exception {
factory = new DuoSDKClientFactory();
@@ -77,12 +81,12 @@ public class DuoSDKClientFactoryTest {
public final void testCreateInstance() throws DuoClientException {
final List<String> certs = new ArrayList<>();
certs.add("sha256/I/Lt/z7ekCWanjD0Cvj5EqXls2lOaThEA0H2Bg4BT/o=");
- DefaultDuoOIDCIntegration integ = new DefaultDuoOIDCIntegration();
+ final DefaultDuoOIDCIntegration integ = new DefaultDuoOIDCIntegration();
integ.setAPIHost("host.com");
integ.setClientId("DIU6GEFWG5LIUBVV2M3P");
integ.setRedirectURI("http://localhost/");
integ.setSecretKey("rFvDfPul27v3Wew2zb6xRPzAJewJ34MP2w8UitPh");
- DuoOIDCClient client = factory.createInstance(integ);
+ final DuoOIDCClient client = factory.createInstance(integ);
assertNotNull(client);
}
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the commits
mailing list