[java-identity-provider] branch main updated: IDP-1706: Enhance StaticPKIXFactoryBean to support PKIXTrustEvaluator...

Brent Putman putmanb at georgetown.edu
Thu Nov 12 22:17:07 UTC 2020


This is an automated email from the git hooks/post-receive script.

putmanb pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=21565f54d874278f2112fc958ca1b6c9cf914f89

The following commit(s) were added to refs/heads/main by this push:
       new  21565f54d IDP-1706: Enhance StaticPKIXFactoryBean to support PKIXTrustEvaluator...
21565f54d is described below

commit 21565f54d874278f2112fc958ca1b6c9cf914f89
Author: Brent Putman <putmanb at georgetown.edu>
AuthorDate: Thu Nov 12 17:16:02 2020 -0500

    IDP-1706: Enhance StaticPKIXFactoryBean to support PKIXTrustEvaluator...
    
    Have factory bean consistently and correctly implement @Nonnull on a
    couple of getters.
---
 .../idp/profile/spring/factory/StaticPKIXFactoryBean.java           | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/factory/StaticPKIXFactoryBean.java b/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/factory/StaticPKIXFactoryBean.java
index 17af5255c..2bafae20a 100644
--- a/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/factory/StaticPKIXFactoryBean.java
+++ b/idp-profile-spring/src/main/java/net/shibboleth/idp/profile/spring/factory/StaticPKIXFactoryBean.java
@@ -186,9 +186,9 @@ public class StaticPKIXFactoryBean extends AbstractComponentAwareFactoryBean<PKI
      * 
      * @return the certificates
      */
-    @Nullable @NonnullElements protected List<X509Certificate> getCertificates() {
+    @Nonnull @NonnullElements protected List<X509Certificate> getCertificates() {
         if (certificateResources == null) {
-            return null;
+            return Collections.emptyList();
         }
         
         final List<X509Certificate> certificates = new ArrayList<>(certificateResources.size());
@@ -210,7 +210,7 @@ public class StaticPKIXFactoryBean extends AbstractComponentAwareFactoryBean<PKI
      */
     @Nonnull @NonnullElements protected List<X509CRL> getCRLs() {
         if (crlResources == null) {
-            return null;
+            return Collections.emptyList();
         }
         
         final List<X509CRL> crls = new ArrayList<>(crlResources.size());

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list