[java-metadata-aggregator] branch master updated: Simplify exception generation in X509ValidationStage

Ian Young ian at iay.org.uk
Fri Mar 13 09:46:08 EDT 2020


This is an automated email from the git hooks/post-receive script.

iay pushed a commit to branch master
in repository java-metadata-aggregator.

View the commit online:
http://git.shibboleth.net/view/?p=java-metadata-aggregator.git;a=commit;h=033c5235be65ead762e57c9fab194604946626e3

The following commit(s) were added to refs/heads/master by this push:
       new  033c523   Simplify exception generation in X509ValidationStage
033c523 is described below

commit 033c5235be65ead762e57c9fab194604946626e3
Author: Ian Young <ian at iay.org.uk>
AuthorDate: Fri Mar 13 13:46:04 2020 +0000

    Simplify exception generation in X509ValidationStage
---
 .../main/java/net/shibboleth/metadata/dom/ds/X509ValidationStage.java  | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/aggregator-pipeline/src/main/java/net/shibboleth/metadata/dom/ds/X509ValidationStage.java b/aggregator-pipeline/src/main/java/net/shibboleth/metadata/dom/ds/X509ValidationStage.java
index 9df68ff..8bb4f06 100644
--- a/aggregator-pipeline/src/main/java/net/shibboleth/metadata/dom/ds/X509ValidationStage.java
+++ b/aggregator-pipeline/src/main/java/net/shibboleth/metadata/dom/ds/X509ValidationStage.java
@@ -29,7 +29,6 @@ import javax.xml.crypto.dsig.XMLSignature;
 
 import org.w3c.dom.Element;
 
-import net.shibboleth.metadata.ErrorStatus;
 import net.shibboleth.metadata.Item;
 import net.shibboleth.metadata.dom.AbstractDOMValidationStage;
 import net.shibboleth.metadata.dom.SimpleDOMTraversalContext;
@@ -117,7 +116,7 @@ public class X509ValidationStage extends AbstractDOMValidationStage<X509Certific
                 applyValidators(cert, context);
             }
         } catch (final CertificateException | DecodingException e) {
-            context.getItem().getItemMetadata().put(new ErrorStatus(getId(), "could not convert X509Certificate data"));
+            addError(context.getItem(), element, "could not convert X509Certficate data");
         }
     }
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list