[java-identity-provider] branch master updated: IDP-1627 - LDAPCredentialValidator isn't logging errors adequately

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=932f3e4290c401ce7a9ab536f695a13920fcd247

The following commit(s) were added to refs/heads/master by this push:
       new  932f3e429 IDP-1627 - LDAPCredentialValidator isn't logging errors adequately
932f3e429 is described below

commit 932f3e4290c401ce7a9ab536f695a13920fcd247
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Mon Jun 29 20:48:01 2020 -0400

    IDP-1627 - LDAPCredentialValidator isn't logging errors adequately
    
    https://issues.shibboleth.net/jira/browse/IDP-1627
---
 .../shibboleth/idp/authn/impl/LDAPCredentialValidator.java   |  3 +--
 .../net/shibboleth/idp/authn/impl/ValidateCredentials.java   | 12 ------------
 2 files changed, 1 insertion(+), 14 deletions(-)

diff --git a/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/LDAPCredentialValidator.java b/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/LDAPCredentialValidator.java
index e44632d74..493decd0a 100644
--- a/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/LDAPCredentialValidator.java
+++ b/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/LDAPCredentialValidator.java
@@ -159,7 +159,6 @@ public class LDAPCredentialValidator extends AbstractUsernamePasswordCredentialV
                 return populateSubject(usernamePasswordContext, response);
             }
             
-            log.info("{} Login by '{}' failed", getLogPrefix(), username);
             authenticationContext.getSubcontext(
                     LDAPResponseContext.class, true).setAuthenticationResponse(response);
             if (AuthenticationResultCode.DN_RESOLUTION_FAILURE == response.getAuthenticationResultCode()
@@ -179,10 +178,10 @@ public class LDAPCredentialValidator extends AbstractUsernamePasswordCredentialV
                 final LdapException e =
                         new LdapException(response.getMessage(), response.getResultCode(), response.getMatchedDn(),
                         response.getControls(), response.getReferralURLs(), response.getMessageId());
-                log.warn("{} Login by {} produced exception", getLogPrefix(), username, e);
                 throw e;
             }
         } catch (final LdapException e) {
+            log.info("{} Login by '{}' failed", getLogPrefix(), username, e);
             if (errorHandler != null) {
                 errorHandler.handleError(profileRequestContext, authenticationContext, e, eventToSignal);
             }
diff --git a/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ValidateCredentials.java b/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ValidateCredentials.java
index f637670b7..33c5fea8f 100644
--- a/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ValidateCredentials.java
+++ b/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ValidateCredentials.java
@@ -157,18 +157,6 @@ public class ValidateCredentials extends AbstractValidationAction implements War
         super.handleError(profileRequestContext, authenticationContext, e, eventId);
     }
     
-    /** {@inheritDoc} */
-    @Override
-    protected boolean doPreExecute(@Nonnull final ProfileRequestContext profileRequestContext,
-            @Nonnull final AuthenticationContext authenticationContext) {
-        
-        if (!super.doPreExecute(profileRequestContext, authenticationContext)) {
-            return false;
-        }
-        
-        return true;
-    }
-
 // Checkstyle: CyclomaticComplexity OFF
     /** {@inheritDoc} */
     @Override

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.