[java-idp-plugin-duo] branch master updated: Minor Javadoc improvements to stop Javadoc failures

[Phil Smart]

This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch master
in repository java-idp-plugin-duo.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-duo.git;a=commit;h=7b64b55c8a19a4b5f3f2d94edf274b92278e545d

The following commit(s) were added to refs/heads/master by this push:
       new  7b64b55   Minor Javadoc improvements to stop Javadoc failures
7b64b55 is described below

commit 7b64b55c8a19a4b5f3f2d94edf274b92278e545d
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Fri Jul 24 12:08:07 2020 +0100

    Minor Javadoc improvements to stop Javadoc failures
---
 .../idp/plugin/authn/duo/AbstractDuoAuthenticationAction.java     | 2 +-
 .../net/shbboleth/idp/plugin/authn/duo/DuoOIDCClientRegistry.java | 7 +++----
 .../idp/plugin/authn/duo/impl/DefaultDuoOIDCClientRegistry.java   | 5 ++---
 idp-duo-impl/src/main/resources/META-INF/plugins/plugin.props     | 8 ++++++++
 4 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/idp-duo-api/src/main/java/net/shbboleth/idp/plugin/authn/duo/AbstractDuoAuthenticationAction.java b/idp-duo-api/src/main/java/net/shbboleth/idp/plugin/authn/duo/AbstractDuoAuthenticationAction.java
index 88d108e..13f85b4 100644
--- a/idp-duo-api/src/main/java/net/shbboleth/idp/plugin/authn/duo/AbstractDuoAuthenticationAction.java
+++ b/idp-duo-api/src/main/java/net/shbboleth/idp/plugin/authn/duo/AbstractDuoAuthenticationAction.java
@@ -100,7 +100,7 @@ public abstract class AbstractDuoAuthenticationAction extends AbstractAuthentica
     }
     
     /**
-     * Delegates to {@link #doExecute(ProfileRequestContext, AuthenticationContext, DuoOIDCClient, 
+     * Delegates to {@link #doExecute(ProfileRequestContext, AuthenticationContext, 
      * DuoOIDCAuthenticationContext)} to perform the actual authentication. Implementations can not 
      * override this method.
      * 
diff --git a/idp-duo-api/src/main/java/net/shbboleth/idp/plugin/authn/duo/DuoOIDCClientRegistry.java b/idp-duo-api/src/main/java/net/shbboleth/idp/plugin/authn/duo/DuoOIDCClientRegistry.java
index e5b8203..354961f 100644
--- a/idp-duo-api/src/main/java/net/shbboleth/idp/plugin/authn/duo/DuoOIDCClientRegistry.java
+++ b/idp-duo-api/src/main/java/net/shbboleth/idp/plugin/authn/duo/DuoOIDCClientRegistry.java
@@ -21,7 +21,6 @@ import javax.annotation.Nonnull;
 
 /**
  * A registry of {@link DuoOIDCClient}s for {@link DuoOIDCIntegration}s.
- * 
  * TODO check this still makes sense
  */
 public interface DuoOIDCClientRegistry {
@@ -29,10 +28,10 @@ public interface DuoOIDCClientRegistry {
     /**
      * Get a Duo client for the given Duo integration. 
      * 
-     * @implSpec Only one client should exist per integration i.e. given the same integration, 
-     * the same client should be returned.
+     * <p>implSpec: Only one client should exist per integration i.e. given the same integration, 
+     * the same client should be returned.</p>
      * 
-     * @implNote Clients can either be pre-registered, or lazy-initialised when first needed.
+     * <p>implNote: Clients can either be pre-registered, or lazy-initialised when first needed.</p>
      *  
      * @param integration the Duo integration to find a client for. Never {@literal null}.
      * 
diff --git a/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/DefaultDuoOIDCClientRegistry.java b/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/DefaultDuoOIDCClientRegistry.java
index 421d33e..7451764 100644
--- a/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/DefaultDuoOIDCClientRegistry.java
+++ b/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/DefaultDuoOIDCClientRegistry.java
@@ -116,8 +116,7 @@ public class DefaultDuoOIDCClientRegistry extends AbstractIdentifiableInitializa
     
     /**
      * A function for creating a new Duo client from the configured client factory for the given Duo integration.
-     * 
-     * @throws DuoClientInitializationException if the factory can not create the client.
+     * throws a {@link DuoClientInitializationException} if the factory can not create the client.
      */
     private class CreateNewClientMappingFunction implements Function<DuoOIDCIntegration, DuoOIDCClient> {
         
@@ -125,7 +124,7 @@ public class DefaultDuoOIDCClientRegistry extends AbstractIdentifiableInitializa
         @Nonnull private final Logger log = LoggerFactory.getLogger(CreateNewClientMappingFunction.class);
         
         @Override
-        public DuoOIDCClient apply(@Nonnull final DuoOIDCIntegration integration) {
+        public DuoOIDCClient apply(@Nonnull final DuoOIDCIntegration integration){
             
             try {
                 log.debug("Creating a new Duo client for integration '{}'",integration);
diff --git a/idp-duo-impl/src/main/resources/META-INF/plugins/plugin.props b/idp-duo-impl/src/main/resources/META-INF/plugins/plugin.props
new file mode 100644
index 0000000..d4b5140
--- /dev/null
+++ b/idp-duo-impl/src/main/resources/META-INF/plugins/plugin.props
@@ -0,0 +1,8 @@
+net.shibboleth.idp.plugin.authn.duo.versions=0.0.1
+#
+# Duo
+# 0.0.1
+#
+net.shibboleth.idp.plugin.authn.duo.idpVersionMax.0.0.1=5.0.0
+net.shibboleth.idp.plugin.authn.duo.idpVersionMin.0.0.1=4.1.0
+net.shibboleth.idp.plugin.authn.duo.supportLevel.0.0.1 = Current

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.