[java-opensaml] branch master updated: Exception message on metadata reload failure was being swallowed.

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository java-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=698ed261e140f20a36c9ba08fb249349ea0586a5

The following commit(s) were added to refs/heads/master by this push:
       new  698ed261e Exception message on metadata reload failure was being swallowed.
698ed261e is described below

commit 698ed261e140f20a36c9ba08fb249349ea0586a5
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Tue Jul 21 17:39:34 2020 -0400

    Exception message on metadata reload failure was being swallowed.
---
 .../saml/metadata/resolver/impl/AbstractReloadingMetadataResolver.java | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/impl/AbstractReloadingMetadataResolver.java b/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/impl/AbstractReloadingMetadataResolver.java
index 12cfc1bd9..113953862 100644
--- a/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/impl/AbstractReloadingMetadataResolver.java
+++ b/opensaml-saml-impl/src/main/java/org/opensaml/saml/metadata/resolver/impl/AbstractReloadingMetadataResolver.java
@@ -373,11 +373,10 @@ public abstract class AbstractReloadingMetadataResolver extends AbstractBatchMet
             trackRefreshSuccess = false;
             lastFailureCause = t;
             nextRefresh = Instant.now().plus(computeNextRefreshDelay(null));
+            log.error("{} Error occurred while attempting to refresh metadata from '{}'", getLogPrefix(), mdId, t);
             if (t instanceof Exception) {
-                log.error("{} Error occurred while attempting to refresh metadata from '{}'", getLogPrefix(), mdId);
                 throw new ResolverException("Exception during refresh", (Exception) t);
             }
-            log.error("{} Error occurred while attempting to refresh metadata from '{}'", getLogPrefix(), mdId, t);
             throw new ResolverException(String.format("Saw an error of type '%s' with message '%s'", 
                     t.getClass().getName(), t.getMessage()));
         } finally {

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.