[java-idp-oidc] branch master updated: Fix Javadoc issues
Ian Young
ian at iay.org.uk
Tue Jan 28 12:45:44 EST 2020
This is an automated email from the git hooks/post-receive script.
iay pushed a commit to branch master
in repository java-idp-oidc.
View the commit online:
http://git.shibboleth.net/view/?p=java-idp-oidc.git;a=commit;h=ec67065fe8601991fadd1eda73c7955c979077b8
The following commit(s) were added to refs/heads/master by this push:
new ec67065 Fix Javadoc issues
ec67065 is described below
commit ec67065fe8601991fadd1eda73c7955c979077b8
Author: Ian Young <ian at iay.org.uk>
AuthorDate: Tue Jan 28 17:45:39 2020 +0000
Fix Javadoc issues
---
.../navigate/TokenRequestRequestedClaimsLookupFunctionTest.java | 4 ++--
.../filter/matcher/impl/AttributeInOIDCRequestedClaimsMatcher.java | 4 ++--
.../oidc/profile/impl/AbstractOIDCUserInfoResponseAction.java | 2 +-
.../org/geant/idpextension/oidc/profile/impl/CheckRedirectURIs.java | 2 +-
.../metadata/impl/ClientInformationResolverServiceStrategy.java | 5 ++++-
.../metadata/impl/ProviderMetadataResolverServiceStrategy.java | 5 ++++-
.../OIDCClientInformationSignatureSigningParametersResolver.java | 2 +-
.../OIDCClientInformationSignatureValidationParametersResolver.java | 2 +-
8 files changed, 16 insertions(+), 10 deletions(-)
diff --git a/idp-oidc-extension-api/src/test/java/org/geant/idpextension/oidc/profile/context/navigate/TokenRequestRequestedClaimsLookupFunctionTest.java b/idp-oidc-extension-api/src/test/java/org/geant/idpextension/oidc/profile/context/navigate/TokenRequestRequestedClaimsLookupFunctionTest.java
index 6dcf9f0..d1302d6 100644
--- a/idp-oidc-extension-api/src/test/java/org/geant/idpextension/oidc/profile/context/navigate/TokenRequestRequestedClaimsLookupFunctionTest.java
+++ b/idp-oidc-extension-api/src/test/java/org/geant/idpextension/oidc/profile/context/navigate/TokenRequestRequestedClaimsLookupFunctionTest.java
@@ -19,7 +19,7 @@ package org.geant.idpextension.oidc.profile.context.navigate;
import org.testng.annotations.Test;
import org.testng.Assert;
-/** Test for {@link TokenRequestRequestedClaimsClaimsLookupFunction}. */
+/** Test for {@link TokenRequestRequestedClaimsLookupFunction}. */
public class TokenRequestRequestedClaimsLookupFunctionTest extends BaseTokenRequestLookupFunctionTest {
private TokenRequestRequestedClaimsLookupFunction lookup = new TokenRequestRequestedClaimsLookupFunction();
@@ -29,4 +29,4 @@ public class TokenRequestRequestedClaimsLookupFunctionTest extends BaseTokenRequ
Assert.assertFalse(lookup.apply(prc).getIDTokenClaims().isEmpty());
}
-}
\ No newline at end of file
+}
diff --git a/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/attribute/filter/matcher/impl/AttributeInOIDCRequestedClaimsMatcher.java b/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/attribute/filter/matcher/impl/AttributeInOIDCRequestedClaimsMatcher.java
index e4097a0..bd1ee4b 100644
--- a/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/attribute/filter/matcher/impl/AttributeInOIDCRequestedClaimsMatcher.java
+++ b/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/attribute/filter/matcher/impl/AttributeInOIDCRequestedClaimsMatcher.java
@@ -210,9 +210,9 @@ public class AttributeInOIDCRequestedClaimsMatcher extends AbstractIdentifiableI
}
/**
- * return a string which is to be prepended to all log messages.
+ * Return a string which is to be prepended to all log messages.
*
- * @return "Attribute Filter '<filterID>' :"
+ * @return "Attribute Filter '<filterID>' :"
*/
@Nonnull
protected String getLogPrefix() {
diff --git a/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/profile/impl/AbstractOIDCUserInfoResponseAction.java b/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/profile/impl/AbstractOIDCUserInfoResponseAction.java
index cacd1ee..5944d10 100644
--- a/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/profile/impl/AbstractOIDCUserInfoResponseAction.java
+++ b/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/profile/impl/AbstractOIDCUserInfoResponseAction.java
@@ -28,7 +28,7 @@ import org.slf4j.LoggerFactory;
/**
*
* Abstract class for actions performing actions on {@link OIDCMetadataContext} located under
- * {@link ProfileRequestContext#getInboundMessageContext() . Extends base classes that offer actions on
+ * {@link ProfileRequestContext#getInboundMessageContext()}. Extends base classes that offer actions on
* {@link UserInfoRequest} found via {@link ProfileRequestContext#getInboundMessageContext()#getMessage()} and on
* {@link OIDCAuthenticationResponseContext} located under {@link ProfileRequestContext#getOutboundMessageContext()}.
*/
diff --git a/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/profile/impl/CheckRedirectURIs.java b/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/profile/impl/CheckRedirectURIs.java
index 4e6bb54..6d16670 100644
--- a/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/profile/impl/CheckRedirectURIs.java
+++ b/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/profile/impl/CheckRedirectURIs.java
@@ -61,7 +61,7 @@ import net.shibboleth.utilities.java.support.logic.Constraint;
* sector_identifier_uri has been defined in the request, all the redirect_uris must exists from the contents behind
* the URI.</p>
*
- * <p>The specification defines the following for <pre>application_type</pre>:</p>
+ * <p>The specification defines the following for <code>application_type</code>:</p>
*
* <p>Web Clients using the OAuth Implicit Grant Type MUST only register URLs using the https scheme as redirect_uris;
* they MUST NOT
diff --git a/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/profile/spring/relyingparty/metadata/impl/ClientInformationResolverServiceStrategy.java b/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/profile/spring/relyingparty/metadata/impl/ClientInformationResolverServiceStrategy.java
index 0193850..7818b1c 100644
--- a/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/profile/spring/relyingparty/metadata/impl/ClientInformationResolverServiceStrategy.java
+++ b/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/profile/spring/relyingparty/metadata/impl/ClientInformationResolverServiceStrategy.java
@@ -37,9 +37,12 @@ import net.shibboleth.utilities.java.support.service.ServiceException;
import net.shibboleth.utilities.java.support.service.ServiceableComponent;
/**
- * Strategy for summoning up a {@link ClientInformationResolver} from a populated {@link ApplicationContext}. <br/>
+ * Strategy for summoning up a {@link ClientInformationResolver} from a populated {@link ApplicationContext}.
+ *
+ * <p>
* The logic is the same as in
* net.shibboleth.idp.profile.spring.relyingparty.metadata.impl.MetadataResolverServiceStrategy.
+ * </p>
*/
public class ClientInformationResolverServiceStrategy extends AbstractIdentifiableInitializableComponent
implements Function<ApplicationContext, ServiceableComponent<ClientInformationResolver>> {
diff --git a/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/profile/spring/relyingparty/metadata/impl/ProviderMetadataResolverServiceStrategy.java b/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/profile/spring/relyingparty/metadata/impl/ProviderMetadataResolverServiceStrategy.java
index bbe03c5..2ab698a 100644
--- a/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/profile/spring/relyingparty/metadata/impl/ProviderMetadataResolverServiceStrategy.java
+++ b/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/profile/spring/relyingparty/metadata/impl/ProviderMetadataResolverServiceStrategy.java
@@ -30,9 +30,12 @@ import net.shibboleth.utilities.java.support.service.ServiceException;
import net.shibboleth.utilities.java.support.service.ServiceableComponent;
/**
- * Strategy for summoning up a {@link ProviderMetadataResolver} from a populated {@link ApplicationContext}. <br/>
+ * Strategy for summoning up a {@link ProviderMetadataResolver} from a populated {@link ApplicationContext}.
+ *
+ * <p>
* The logic is the same as in
* net.shibboleth.idp.profile.spring.relyingparty.metadata.impl.MetadataResolverServiceStrategy.
+ * </p>
*/
public class ProviderMetadataResolverServiceStrategy extends AbstractIdentifiableInitializableComponent
implements Function<ApplicationContext, ServiceableComponent<ProviderMetadataResolver>> {
diff --git a/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/security/impl/OIDCClientInformationSignatureSigningParametersResolver.java b/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/security/impl/OIDCClientInformationSignatureSigningParametersResolver.java
index 12f686f..79c33df 100644
--- a/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/security/impl/OIDCClientInformationSignatureSigningParametersResolver.java
+++ b/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/security/impl/OIDCClientInformationSignatureSigningParametersResolver.java
@@ -49,10 +49,10 @@ import com.nimbusds.openid.connect.sdk.rp.OIDCClientInformation;
* <p>
* In addition to the {@link net.shibboleth.utilities.java.support.resolver.Criterion} inputs documented in
* {@link BasicSignatureSigningParametersResolver}, the following inputs are also supported:
+ * </p>
* <ul>
* <li>{@link ClientInformationCriterion} - optional</li>
* </ul>
- * </p>
*/
public class OIDCClientInformationSignatureSigningParametersResolver extends BasicSignatureSigningParametersResolver {
diff --git a/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/security/impl/OIDCClientInformationSignatureValidationParametersResolver.java b/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/security/impl/OIDCClientInformationSignatureValidationParametersResolver.java
index 1b4d923..70ca135 100644
--- a/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/security/impl/OIDCClientInformationSignatureValidationParametersResolver.java
+++ b/idp-oidc-extension-impl/src/main/java/org/geant/idpextension/oidc/security/impl/OIDCClientInformationSignatureValidationParametersResolver.java
@@ -56,10 +56,10 @@ import com.nimbusds.jose.jwk.AsymmetricJWK;
* <p>
* In addition to the {@link net.shibboleth.utilities.java.support.resolver.Criterion} inputs documented in
* {@link BasicSignatureSigningParametersResolver}, the following inputs are also supported:
+ * </p>
* <ul>
* <li>{@link ClientInformationCriterion} - optional</li>
* </ul>
- * </p>
*/
public class OIDCClientInformationSignatureValidationParametersResolver
extends BasicSignatureSigningParametersResolver {
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the commits
mailing list