[java-parent-project] branch master updated: IDP-1465 - Remove explicit management of spring-core's logging dependency

[Ian Young]

This is an automated email from the git hooks/post-receive script.

iay pushed a commit to branch master
in repository java-parent-project.

View the commit online:
http://git.shibboleth.net/view/?p=java-parent-project.git;a=commit;h=87ce87e6640f72fbe96038936e48e8c228f6ecd8

The following commit(s) were added to refs/heads/master by this push:
       new  87ce87e   IDP-1465 - Remove explicit management of spring-core's logging dependency
87ce87e is described below

commit 87ce87e6640f72fbe96038936e48e8c228f6ecd8
Author: Ian Young <ian at iay.org.uk>
AuthorDate: Tue Jan 21 11:07:27 2020 +0000

    IDP-1465 - Remove explicit management of spring-core's logging dependency
    
    Document how we are handling log bridging in applications.
    As a result of Spring 5's use of its own spring-jcl instead of commons-logging, we no longer need to exclude commons-logging and as a result no longer need to manage that module explicitly.
---
 pom.xml | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/pom.xml b/pom.xml
index b5a4d57..7940a1a 100644
--- a/pom.xml
+++ b/pom.xml
@@ -366,18 +366,6 @@
                 <scope>import</scope>
             </dependency>
             <dependency>
-                <groupId>${spring.groupId}</groupId>
-                <artifactId>spring-core</artifactId>
-                <version>${spring.version}</version>
-                <!-- Spring Framework's logging dependencies are centralised in spring-core. -->
-                <exclusions>
-                    <exclusion>
-                        <groupId>commons-logging</groupId>
-                        <artifactId>commons-logging</artifactId>
-                    </exclusion>
-                </exclusions>
-            </dependency>
-            <dependency>
                 <groupId>org.cryptacular</groupId>
                 <artifactId>cryptacular</artifactId>
                 <version>${cryptacular.version}</version>
@@ -458,6 +446,18 @@
                 <version>1.2</version>
                 <scope>provided</scope>
             </dependency>
+
+            <!--
+                Logging bridge for commons logging.
+
+                If the application is based on Spring Framework, this function
+                will be provided by the spring-jcl artifact which is a dependency
+                of spring-core.
+
+                If the application is NOT Spring-based, it should have a
+                dependency on jcl-over-slf4j instead, with "runtime" scope,
+                overriding the "provided" below.
+            -->
 	        <dependency>
 	            <groupId>${slf4j.groupId}</groupId>
 	            <artifactId>jcl-over-slf4j</artifactId>

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.