[cpp-opensaml] branch master updated: Logging cleanup.

Scott Cantor cantor.2 at osu.edu
Tue Feb 25 21:09:25 EST 2020


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository cpp-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=cpp-opensaml.git;a=commit;h=735386333a8fc16a2e8b6762bab763ae4ab64898

The following commit(s) were added to refs/heads/master by this push:
       new  7353863   Logging cleanup.
7353863 is described below

commit 735386333a8fc16a2e8b6762bab763ae4ab64898
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Tue Feb 25 21:09:15 2020 -0500

    Logging cleanup.
---
 saml/binding/impl/MessageFlowRule.cpp              | 7 +++++--
 saml/saml2/profile/impl/BearerConfirmationRule.cpp | 3 +++
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/saml/binding/impl/MessageFlowRule.cpp b/saml/binding/impl/MessageFlowRule.cpp
index 1b0f965..f8beac1 100644
--- a/saml/binding/impl/MessageFlowRule.cpp
+++ b/saml/binding/impl/MessageFlowRule.cpp
@@ -124,11 +124,14 @@ bool MessageFlowRule::evaluate(const XMLObject& message, const GenericRequest* r
         }
         else if (policy.getInResponseTo() && *(policy.getInResponseTo())) {
             log.warn("request/response correlation failed due to lack of request ID to compare");
-            throw SecurityPolicyException("Response correlation failed with lack of correlation ID");
+            throw SecurityPolicyException("Response correlation failed with lack of correlation ID.");
         }
         else if (m_blockUnsolicited) {
             log.warn("unsolicited response rejected by policy");
-            throw SecurityPolicyException("Unsolicited response rejected by policy");
+            throw SecurityPolicyException("Unsolicited response rejected by policy.");
+        }
+        else {
+            log.debug("unsolicited response accepted");
         }
     }
     else {
diff --git a/saml/saml2/profile/impl/BearerConfirmationRule.cpp b/saml/saml2/profile/impl/BearerConfirmationRule.cpp
index 2acbae9..3723d21 100644
--- a/saml/saml2/profile/impl/BearerConfirmationRule.cpp
+++ b/saml/saml2/profile/impl/BearerConfirmationRule.cpp
@@ -140,6 +140,9 @@ bool BearerConfirmationRule::evaluate(const XMLObject& message, const GenericReq
                         msg = "unsolicited bearer confirmation rejected by policy";
                         continue;
                     }
+                    else {
+                        m_log.debug("unsolicited response accepted");
+                    }
                 }
                 else {
                     m_log.debug("ignoring InResponseTo, correlation checking is disabled");

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list