[cpp-opensaml] branch master updated: SSPCPP-883 - Allow blocking of unsolicited SSO

Scott Cantor cantor.2 at osu.edu
Tue Feb 25 15:33:09 EST 2020


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository cpp-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=cpp-opensaml.git;a=commit;h=1deba1c0de42711189918a45edfa53445aa90c5e

The following commit(s) were added to refs/heads/master by this push:
       new  1deba1c   SSPCPP-883 - Allow blocking of unsolicited SSO
1deba1c is described below

commit 1deba1c0de42711189918a45edfa53445aa90c5e
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Tue Feb 25 15:31:42 2020 -0500

    SSPCPP-883 - Allow blocking of unsolicited SSO
    
    https://issues.shibboleth.net/jira/browse/SSPCPP-883
    
    Fix name of block flag in policy checks.
---
 saml/binding/impl/MessageFlowRule.cpp              | 2 +-
 saml/saml2/profile/impl/BearerConfirmationRule.cpp | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/saml/binding/impl/MessageFlowRule.cpp b/saml/binding/impl/MessageFlowRule.cpp
index d4cea01..1b0f965 100644
--- a/saml/binding/impl/MessageFlowRule.cpp
+++ b/saml/binding/impl/MessageFlowRule.cpp
@@ -126,7 +126,7 @@ bool MessageFlowRule::evaluate(const XMLObject& message, const GenericRequest* r
             log.warn("request/response correlation failed due to lack of request ID to compare");
             throw SecurityPolicyException("Response correlation failed with lack of correlation ID");
         }
-        else if (blockUnsolicited) {
+        else if (m_blockUnsolicited) {
             log.warn("unsolicited response rejected by policy");
             throw SecurityPolicyException("Unsolicited response rejected by policy");
         }
diff --git a/saml/saml2/profile/impl/BearerConfirmationRule.cpp b/saml/saml2/profile/impl/BearerConfirmationRule.cpp
index b038a2a..2acbae9 100644
--- a/saml/saml2/profile/impl/BearerConfirmationRule.cpp
+++ b/saml/saml2/profile/impl/BearerConfirmationRule.cpp
@@ -136,7 +136,7 @@ bool BearerConfirmationRule::evaluate(const XMLObject& message, const GenericReq
                         msg = "bearer confirmation issued in response to request failed on lack of correlation ID";
                         continue;
                     }
-                    else if (blockUnsolicited) {
+                    else if (m_blockUnsolicited) {
                         msg = "unsolicited bearer confirmation rejected by policy";
                         continue;
                     }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list