[java-opensaml] 04/04: Add missing param Javadocs to SAML 2 Assertion validator.

[Brent Putman]

This is an automated email from the git hooks/post-receive script.

putmanb pushed a commit to branch master
in repository java-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=873e0eca385eb20f5fd0d210f32ee619f606f20d

commit 873e0eca385eb20f5fd0d210f32ee619f606f20d
Author: Brent Putman <putmanb at georgetown.edu>
AuthorDate: Sat Feb 1 00:26:09 2020 -0500

    Add missing param Javadocs to SAML 2 Assertion validator.
---
 .../saml/saml2/assertion/SAML20AssertionValidator.java      | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/assertion/SAML20AssertionValidator.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/assertion/SAML20AssertionValidator.java
index 1b70dea..692447b 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/assertion/SAML20AssertionValidator.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/saml2/assertion/SAML20AssertionValidator.java
@@ -68,6 +68,10 @@ import org.w3c.dom.Element;
  *
  * <ul>
  * <li>
+ * {@link SAML2AssertionValidationParameters#VALID_ISSUERS}:
+ * Optional.
+ * </li>
+ * <li>
  * {@link SAML2AssertionValidationParameters#SIGNATURE_REQUIRED}:
  * Optional.
  * If not supplied, defaults to 'true'. If an Assertion is signed, the signature is always evaluated 
@@ -97,6 +101,10 @@ import org.w3c.dom.Element;
  * If not present the default clock skew of {@link SAML20AssertionValidator#DEFAULT_CLOCK_SKEW} 
  * will be used.
  * </li>
+ * <li>
+ * {@link SAML2AssertionValidationParameters#COND_REQUIRED_CONDITIONS}:
+ * Optional.
+ * </li>
  * </ul>
  * 
  * <p>
@@ -338,8 +346,9 @@ public class SAML20AssertionValidator {
         if (validIssuers == null || validIssuers.isEmpty()) {
             log.warn("Set of valid issuers was not available from the validation context, unable to evaluate Issuer");
             return ValidationResult.VALID;
-            /* TODO this should really be indeterminate, but would change the behavior for older code.
-               Need to update that first.
+            /* TODO this should really be indeterminate, but would change the behavior for older code. Need to update:
+               org.opensaml.saml.saml2.wssecurity.messaging.impl.DefaultSAML20AssertionValidationContextBuilder.
+               Also change Javadocs on this class to indicate 'Required' rather than 'Optional'.
             context.setValidationFailureMessage("Unable to determine list of valid issuers");
             return ValidationResult.INDETERMINATE;
             */

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.