[java-idp-plugin-duo] branch main updated: Remove unnecessary DuoPrincipal test

Phil Smart philip.smart at jisc.ac.uk
Wed Aug 26 13:05:18 UTC 2020


This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-duo.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-duo.git;a=commit;h=bfa1f27caf7e753d8f0176b178ba32082ab0dfd5

The following commit(s) were added to refs/heads/main by this push:
       new  bfa1f27   Remove unnecessary DuoPrincipal test
bfa1f27 is described below

commit bfa1f27caf7e753d8f0176b178ba32082ab0dfd5
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Wed Aug 26 14:05:11 2020 +0100

    Remove unnecessary DuoPrincipal test
---
 .../plugin/authn/duo/principal/package-info.java   | 19 ----------
 .../idp/plugin/authn/duo/DuoOIDCPrincipalTest.java | 43 ----------------------
 2 files changed, 62 deletions(-)

diff --git a/idp-duo-api/src/main/java/net/shbboleth/idp/plugin/authn/duo/principal/package-info.java b/idp-duo-api/src/main/java/net/shbboleth/idp/plugin/authn/duo/principal/package-info.java
deleted file mode 100644
index 81248d9..0000000
--- a/idp-duo-api/src/main/java/net/shbboleth/idp/plugin/authn/duo/principal/package-info.java
+++ /dev/null
@@ -1,19 +0,0 @@
-/*
- * Licensed to the University Corporation for Advanced Internet Development,
- * Inc. (UCAID) under one or more contributor license agreements.  See the
- * NOTICE file distributed with this work for additional information regarding
- * copyright ownership. The UCAID licenses this file to You under the Apache
- * License, Version 2.0 (the "License"); you may not use this file except in
- * compliance with the License.  You may obtain a copy of the License at
- *
- *    http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-/** Duo OIDC 2FA login flow principal classes. */
-package net.shbboleth.idp.plugin.authn.duo.principal;
diff --git a/idp-duo-api/src/test/java/net/shbboleth/idp/plugin/authn/duo/DuoOIDCPrincipalTest.java b/idp-duo-api/src/test/java/net/shbboleth/idp/plugin/authn/duo/DuoOIDCPrincipalTest.java
deleted file mode 100644
index 4906920..0000000
--- a/idp-duo-api/src/test/java/net/shbboleth/idp/plugin/authn/duo/DuoOIDCPrincipalTest.java
+++ /dev/null
@@ -1,43 +0,0 @@
-package net.shbboleth.idp.plugin.authn.duo;
-
-
-import static org.testng.Assert.assertEquals;
-
-import org.testng.annotations.Test;
-
-import net.shbboleth.idp.plugin.authn.duo.principal.DuoOIDCPrincipal;
-
-/**
- * Test for the {@link DuoOIDCPrincipal}.
- */
-public class DuoOIDCPrincipalTest {
-
-    /**
-     * Test principal cloning.
-     * 
-     * @throws CloneNotSupportedException on error
-     */
-    @Test 
-    public void testClone() throws CloneNotSupportedException {
-        final String name = "jdoe";
-        final DuoOIDCPrincipal principal = new DuoOIDCPrincipal(name);
-        final DuoOIDCPrincipal principalTwo = principal.clone();
-        assertEquals(principal, principalTwo);       
-    }
-    
-    /**
-     * Test name is not mutable.
-     * 
-     * @throws CloneNotSupportedException on error
-     */
-    @Test 
-    public void testImmutable() throws CloneNotSupportedException {
-        final String name = "jdoe";
-        final DuoOIDCPrincipal principal = new DuoOIDCPrincipal(name);
-        //should be obvious as string is not mutable. But dbl check.
-        String nameInPrincipal = principal.getName();
-        nameInPrincipal = "jdoe-modified";
-        assertEquals(principal.getName(), name);       
-    }
-
-}

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list