[java-metadata-aggregator] branch main updated: Simplify test by refactoring using try-with-resources

Ian Young ian at iay.org.uk
Wed Aug 19 16:03:17 UTC 2020


This is an automated email from the git hooks/post-receive script.

iay pushed a commit to branch main
in repository java-metadata-aggregator.

View the commit online:
http://git.shibboleth.net/view/?p=java-metadata-aggregator.git;a=commit;h=af67cf3612079e1ace1b9cd10c11fad5db666f72

The following commit(s) were added to refs/heads/main by this push:
       new  af67cf3   Simplify test by refactoring using try-with-resources
af67cf3 is described below

commit af67cf3612079e1ace1b9cd10c11fad5db666f72
Author: Ian Young <ian at iay.org.uk>
AuthorDate: Wed Aug 19 17:03:13 2020 +0100

    Simplify test by refactoring using try-with-resources
---
 .../FilesInDirectoryMultiOutputStrategyTest.java       | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/aggregator-pipeline/src/test/java/net/shibboleth/metadata/pipeline/FilesInDirectoryMultiOutputStrategyTest.java b/aggregator-pipeline/src/test/java/net/shibboleth/metadata/pipeline/FilesInDirectoryMultiOutputStrategyTest.java
index c1eaeb4..c3c6e6d 100644
--- a/aggregator-pipeline/src/test/java/net/shibboleth/metadata/pipeline/FilesInDirectoryMultiOutputStrategyTest.java
+++ b/aggregator-pipeline/src/test/java/net/shibboleth/metadata/pipeline/FilesInDirectoryMultiOutputStrategyTest.java
@@ -66,11 +66,10 @@ public class FilesInDirectoryMultiOutputStrategyTest {
         
         final Item<String> item = new MockItem("mocked");
         item.getItemMetadata().put(new ItemId("abc"));
-        final MultiOutputSerializationStage.Destination dest = strategy.getDestination(item);
-        final OutputStream os = dest.getOutputStream();
-        os.write('a');
-        os.close();
-        dest.close();
+        try (MultiOutputSerializationStage.Destination dest = strategy.getDestination(item);
+                OutputStream os = dest.getOutputStream()) {
+            os.write('a');
+        }
         
         checkOneFile(tempDir, "preabcabc.txt");
         wipeDirectory(tempDir);
@@ -87,11 +86,10 @@ public class FilesInDirectoryMultiOutputStrategyTest {
         
         final Item<String> item = new MockItem("mocked");
         item.getItemMetadata().put(new ItemId("abc"));
-        final MultiOutputSerializationStage.Destination dest = strategy.getDestination(item);
-        final OutputStream os = dest.getOutputStream();
-        os.write('a');
-        os.close();
-        dest.close();
+        try (MultiOutputSerializationStage.Destination dest = strategy.getDestination(item);
+                OutputStream os = dest.getOutputStream()) {
+            os.write('a');
+        }
         
         checkOneFile(tempDir, "abc");
         wipeDirectory(tempDir);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list