[java-idp-plugin-duo] branch master updated: Fix calls to deprecated recordFailure and recordSuccess methods.

Phil Smart philip.smart at jisc.ac.uk
Mon Aug 3 08:57:50 UTC 2020


This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch master
in repository java-idp-plugin-duo.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-duo.git;a=commit;h=63224bc132cd18affaff5a2e577d8c23b17d1e7d

The following commit(s) were added to refs/heads/master by this push:
       new  63224bc   Fix calls to deprecated recordFailure and recordSuccess methods.
63224bc is described below

commit 63224bc132cd18affaff5a2e577d8c23b17d1e7d
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Mon Aug 3 09:57:48 2020 +0100

    Fix calls to deprecated recordFailure and recordSuccess methods.
---
 .../authn/duo/impl/ValidateDuoTokenAuthenticationResult.java   | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/ValidateDuoTokenAuthenticationResult.java b/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/ValidateDuoTokenAuthenticationResult.java
index e6f39c9..959dc16 100644
--- a/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/ValidateDuoTokenAuthenticationResult.java
+++ b/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/ValidateDuoTokenAuthenticationResult.java
@@ -78,7 +78,7 @@ public class ValidateDuoTokenAuthenticationResult extends AbstractValidationActi
             log.info("{} No DuoAuthenticationContext available", getLogPrefix());
             handleError(profileRequestContext, authenticationContext, "No DuoAuthenticationContext context available",
                     AuthnEventIds.INVALID_AUTHN_CTX);
-            recordFailure();
+            recordFailure(profileRequestContext);
             return false;
         }         
         //we get username from the original context, not the duo response.
@@ -97,25 +97,25 @@ public class ValidateDuoTokenAuthenticationResult extends AbstractValidationActi
             handleError(profileRequestContext, authenticationContext,"Duo 2FA result not available",
                     AuthnEventIds.INVALID_CREDENTIALS);
             ActionSupport.buildEvent(profileRequestContext, AuthnEventIds.INVALID_CREDENTIALS);
-            recordFailure();
+            recordFailure(profileRequestContext);
             return;
         }
         
         if (DuoOIDCAuthAPI.DUO_AUTH_RESULT_ALLOW.equalsIgnoreCase(token.getAuthResultStatus())){
             log.debug("{} Duo 2FA authentication succeeded for '{}'",getLogPrefix(),duoContext.getUsername());
-            recordSuccess();
+            recordSuccess(profileRequestContext);
             buildAuthenticationResult(profileRequestContext, authenticationContext);
         } else if (DuoOIDCAuthAPI.DUO_AUTH_RESULT_DENY.equalsIgnoreCase(token.getAuthResultStatus())) {
             log.error("{} Duo 2FA failed for '{}', 2FA status '{}'",getLogPrefix(), username,
                     token.getAuthResultStatusMessage());
             handleError(profileRequestContext, authenticationContext, token.getAuthResultStatus(),
                     AuthnEventIds.INVALID_CREDENTIALS);
-            recordFailure();
+            recordFailure(profileRequestContext);
         } else {        
             log.error("{} Duo 2FA access failed for '{}', unknown response", getLogPrefix(), username);
             handleError(profileRequestContext, authenticationContext,"Unexepected Authentication Response", 
                     AuthnEventIds.AUTHN_EXCEPTION);
-            recordFailure();
+            recordFailure(profileRequestContext);
         }
     }
     

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list