[java-opensaml] branch master updated: Revert "Streamline collection copy."

Scott Cantor cantor.2 at osu.edu
Mon Oct 21 10:19:29 EDT 2019


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository java-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=42bf7b738c2b846debd786eb7b965eed3ff5f774

The following commit(s) were added to refs/heads/master by this push:
       new  42bf7b7   Revert "Streamline collection copy."
42bf7b7 is described below

commit 42bf7b738c2b846debd786eb7b965eed3ff5f774
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Mon Oct 21 10:19:14 2019 -0400

    Revert "Streamline collection copy."
    
    This reverts commit f8c94e8c0d04e7e0e5613bc3a92cb0443420d301.
---
 .../opensaml/saml/metadata/resolver/filter/MetadataFilterChain.java | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/resolver/filter/MetadataFilterChain.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/resolver/filter/MetadataFilterChain.java
index 6baf68a..13235f5 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/resolver/filter/MetadataFilterChain.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/metadata/resolver/filter/MetadataFilterChain.java
@@ -17,6 +17,7 @@
 
 package org.opensaml.saml.metadata.resolver.filter;
 
+import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
 
@@ -31,6 +32,9 @@ import org.opensaml.core.xml.XMLObject;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import com.google.common.base.Predicates;
+import com.google.common.collect.Collections2;
+
 /**
  * A filter that allows the composition of {@link MetadataFilter}s. Filters will be executed on the given metadata
  * document in the order they were added to the chain.
@@ -94,7 +98,7 @@ public class MetadataFilterChain implements MetadataFilter {
     public void setFilters(@Nonnull @NonnullElements final List<MetadataFilter> newFilters) {
         Constraint.isNotNull(newFilters, "Filter collection cannot be null");
         
-        filters = List.copyOf(newFilters);
+        filters = new ArrayList<>(Collections2.filter(newFilters, Predicates.notNull()));
     }
     
 }
\ No newline at end of file

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list